Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaBufferIT tests for writeBytes #3645

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

dlvenable
Copy link
Member

Description

This PR follows on after #3635 with some integration test improvements.

  • Adds a test case to verify that raw bytes are wrapped in the Protobuf message.
  • Adds a test case to verify that raw bytes are wrapped in the Protobuf message and encrypted when encryption is configured.
  • Verifies the Event received after calling writeBytes. This adds a verification to an existing test case that should have been there.
  • Some test naming improvements
  • Adding final modifiers.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…wrapped in the Protobuf Kafka message wrapper. Adds a missing validation when reading data after a writeBytes call and some other minor test improvements.

Signed-off-by: David Venable <[email protected]>
@dlvenable
Copy link
Member Author

@kkondaka , Please take a look and see if the new tests address your concerns from this comment. #3635 (comment)

@dlvenable dlvenable merged commit ba8cf9d into opensearch-project:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants