Add parse_ion processor #3803
Merged
Add parse_ion processor #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emma Becar <[email protected]>
emmachase
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
4 tasks
graytaylor0
previously approved these changes
Dec 4, 2023
dlvenable
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Thank you @emmachase. I have a few comments to address. Other than that, we'll want to be sure it builds. Then we should be good to merge it in.
...src/main/java/org/opensearch/dataprepper/plugins/processor/parse/AbstractParseProcessor.java
Outdated
Show resolved
Hide resolved
...java/org/opensearch/dataprepper/plugins/processor/parse/ion/IonTimestampConverterModule.java
Show resolved
Hide resolved
...java/org/opensearch/dataprepper/plugins/processor/parse/ion/IonTimestampConverterModule.java
Show resolved
Hide resolved
...ssor/src/main/java/org/opensearch/dataprepper/plugins/processor/parse/CommonParseConfig.java
Show resolved
Hide resolved
Signed-off-by: Emma Becar <[email protected]>
Signed-off-by: Emma Becar <[email protected]>
|
@dlvenable Thanks for the review, the latest commits should resolve your comments :) |
dlvenable
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
This looks good. Thank you @emmachase for this contribution!
graytaylor0
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add parse_ion processor.
This collects most of the logic based on the common config options into an abstract class AbstractParseProcessor.
Since Ion is a superset of JSON, I inherited the JSON test suite for the Ion processor, and added an additional test to ensure that the Ion specific features work correctly.
Note: Since eventually the parsed objects need to be converted to JSON, Ion Timestamps are parsed into ISO-8601 Z strings. Ion Blobs are parsed into base64 encoded strings as per default Jackson behavior. Annotations are currently stripped entirely; in the future we could possibly add config options to support exposing them as extra fields (e.g.
{foo: bar::"baz"}=>{"foo": "baz", "foo$annotations": ["bar"]}).Documentation Issue: opensearch-project/documentation-website#5769
Issues Resolved
Resolves #3730
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.