Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Add dissect processor documentation #5510

Merged
merged 67 commits into from
Jan 29, 2024
Merged

[DOC] Add dissect processor documentation #5510

merged 67 commits into from
Jan 29, 2024

Conversation

vagimeli
Copy link
Contributor

@vagimeli vagimeli commented Nov 3, 2023 •
edited by hdhalter
Loading

Description

Address content gap for ingest processors documentation. Adds new content for dissect processor.

Issues Resolved

Fixes #4647

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli vagimeli added 2 - In progress Issue/PR: The issue or PR is in progress. Content gap labels Nov 3, 2023
@vagimeli vagimeli self-assigned this Nov 3, 2023
@vagimeli vagimeli mentioned this pull request Nov 3, 2023
Closed
45 tasks
@vagimeli
Copy link
Contributor Author

vagimeli commented Nov 6, 2023

@heemin32 Please review the new dissect processor when you have availability. Thank you, Melissa

@heemin32
Copy link
Contributor

heemin32 commented Nov 8, 2023

@heemin32 Please review the new dissect processor when you have availability. Thank you, Melissa

Will try to review it but I am fully occupied with other works. Could you also check with others to see if they can review it?

@vagimeli
Copy link
Contributor Author

vagimeli commented Nov 8, 2023

@heemin32 Please review the new dissect processor when you have availability. Thank you, Melissa

Will try to review it but I am fully occupied with other works. Could you also check with others to see if they can review it?

Yes, will do. Thanks Heemin :)

@vagimeli vagimeli added 3 - Tech review PR: Tech review in progress 4 - Doc review PR: Doc review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Nov 14, 2023
@vagimeli
Copy link
Contributor Author

vagimeli commented Nov 17, 2023 •
edited
Loading

@vamshin This PR is ready for technical review by your team. Thanks for helping move it forward :)

cc: @hdhalter for visibility

@vagimeli
Update dissect.md
8a33fa7 
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Copy link
Contributor Author

@vamshin This PR is ready for technical review by your team. Thanks for helping move it forward :)

cc: @hdhalter for visibility

Hi @vamshin, Do we have a dev who can review this content for technical accuracy? Thanks, Melissa

@vamshin
Copy link
Member

vamshin commented Nov 28, 2023

@vamshin This PR is ready for technical review by your team. Thanks for helping move it forward :)
cc: @hdhalter for visibility

Hi @vamshin, Do we have a dev who can review this content for technical accuracy? Thanks, Melissa

@vagimeli not sure the right dev for this. Adding Search pipelines dev for insights @macohen @msfroh

@vagimeli
Copy link
Contributor Author

vagimeli commented Dec 1, 2023 •
edited
Loading

Hi @macohen & @msfroh, Will you review, or direct me to the appropriate reviewer, for the ingest processor documentation? We're working through content gaps and need dev reviewers to vet technical accuracy. Thank you.

META issue for reference #4647

vagimeli and others added 23 commits January 29, 2024 09:43
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
c7d1e04 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
5b13a02 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
a6d8d42 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
1c95dfe 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Update dissect.md
736ca78 
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
472d152 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Update dissect.md
fe54378 
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
91885c4 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
4818868 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
19bb826 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
240f709 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
f31da78 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Update dissect.md
fa99869 
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
4e0418f 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
0022732 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
b0bf080 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli @natebower
Update _ingest-pipelines/processors/dissect.md
3eb5330 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Update dissect.md
5d6a747 
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Update dissect.md
5a4c9bb 
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Update dissect.md
59f4e82 
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Update dissect.md
84ff483 
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Update dissect.md
f17c8d8 
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli
Merge branch 'main' into dissect
a95c46d
@vagimeli vagimeli added backport 2.11 PR: Backport label for 2.11 and removed 5 - Editorial review PR: Editorial review in progress labels Jan 29, 2024
@vagimeli vagimeli merged commit d350485 into main Jan 29, 2024
4 of 5 checks passed
@vagimeli vagimeli deleted the dissect branch January 29, 2024 18:05
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 29, 2024
@github-actions @kolchfa-aws @natebower
[DOC] Add dissect processor documentation (#5510)
545b392 
* Close content gap with new documentation for OpenSearch dissect processor

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit d350485)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 29, 2024
Merged
vagimeli pushed a commit that referenced this pull request Jan 29, 2024
@opensearch-trigger-bot @github-actions
@kolchfa-aws @natebower
[DOC] Add dissect processor documentation (#5510) (#6277)
37957d4 
* Close content gap with new documentation for OpenSearch dissect processor

---------




(cherry picked from commit d350485)

Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@msfroh msfroh msfroh left review comments

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@ananzh ananzh Awaiting requested review from ananzh

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

Assignees

@vagimeli vagimeli

Labels
backport 2.11 PR: Backport label for 2.11 Content gap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META DOC] Ingest Processors Content Gaps
7 participants
@vagimeli @heemin32 @vamshin @msfroh @natebower @kolchfa-aws @hdhalter