Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for configuring the password hashing algorithm and its properties #7697

Merged

Conversation

dancristiancecoi
Copy link
Contributor

@dancristiancecoi dancristiancecoi commented Jul 12, 2024

Description

Added documentation for configuring the password hashing algorithm and its properties

Issues Resolved

Closes #7669

Version

2.16. 3.x

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dancristiancecoi
Copy link
Contributor Author

Hey @scrawfor99 could I get this reviewed please so we have it ready for 2.16?

@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Jul 22, 2024
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions and a clarification. Otherwise, LGTM.

@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Jul 24, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS @dancristiancecoi Just a couple of changes. Thanks!

@Naarcha-AWS Naarcha-AWS merged commit c561f32 into opensearch-project:main Jul 24, 2024
5 checks passed
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 5 - Editorial review PR: Editorial review in progress labels Jul 30, 2024
sandervandegeijn pushed a commit to sandervandegeijn/documentation-website that referenced this pull request Jul 30, 2024
…its properties (opensearch-project#7697)

* Add documentation for configuring the password hashing algorithms and their properties

Signed-off-by: Dan Cecoi <[email protected]>

* Small change to the warning message

Signed-off-by: Dan Cecoi <[email protected]>

* Modified the warning message and its placement

Signed-off-by: Dan Cecoi <[email protected]>

* modified the bcrypt.rounds explanation

Signed-off-by: Dan Cecoi <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: Dan Cecoi <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Dan Cecoi <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Sander van de Geijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add documentation for configuring the password hashing algorithm
6 participants