Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Amazon S3 data source #8109

Merged
merged 11 commits into from
Aug 29, 2024
Merged

Revise Amazon S3 data source #8109

merged 11 commits into from
Aug 29, 2024

Conversation

vagimeli
Copy link
Contributor

Description

REvises text for clarity and conciseness

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Version

List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@vagimeli vagimeli added 4 - Doc review PR: Doc review in progress backport 2.16 labels Aug 27, 2024
_dashboards/management/S3-data-source.md Outdated Show resolved Hide resolved
Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Aug 28, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Just a few minor changes. Thanks!

_dashboards/management/S3-data-source.md Outdated Show resolved Hide resolved
<img src="{{site.url}}{{site.baseurl}}/images/dashboards/manage-data-source-UI.png" alt="Manage data sources UI" width="700"/>

3. (Optional) Explore the Amazon S3 use cases, including querying your data and optimizing query performance. Go to **Next steps** to learn more about each use case.
2. On the data source's page, you can manage the data source, choose a use case, and configure access controls.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"On the page for the data source"?

_dashboards/management/S3-data-source.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
@vagimeli vagimeli merged commit 98e8788 into main Aug 29, 2024
6 checks passed
@vagimeli vagimeli deleted the update-data-sources-S3 branch August 29, 2024 23:29
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 29, 2024
* Revise text for clarity and conciseness

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 98e8788)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Aug 29, 2024
epugh pushed a commit to o19s/documentation-website that referenced this pull request Sep 12, 2024
* Revise text for clarity and conciseness

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update _dashboards/management/S3-data-source.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Editorial review PR: Editorial review in progress backport 2.16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants