Integrate multitenancy into workflow provisioning #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharthabingi
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
reviewed
Jan 22, 2025
src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
dbwiddis
reviewed
Jan 22, 2025
src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/AbstractCreatePipelineStep.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateConnectorStep.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/ProcessNode.java
Outdated
Show resolved
Hide resolved
siddharthabingi
force-pushed
the
multiTenancyWF
branch
from
e440dc1 to
496c09a
Compare
added 4 commits
January 22, 2025 14:48
Signed-off-by: Siddhartha Bingi <[email protected]>
Signed-off-by: Siddhartha Bingi <[email protected]>
Signed-off-by: Siddhartha Bingi <[email protected]>
Signed-off-by: Siddhartha Bingi <[email protected]>
siddharthabingi
force-pushed
the
multiTenancyWF
branch
from
496c09a to
16e2f2d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1012 +/- ##
============================================
- Coverage 76.40% 76.39% -0.02%
Complexity 1010 1010
============================================
Files 100 100
Lines 4879 4881 +2
Branches 455 455
============================================
+ Hits 3728 3729 +1
- Misses 954 955 +1
Partials 197 197 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Jan 23, 2025
owaiskazi19
approved these changes
Jan 23, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Adding tenantId in ProcessNode to be surfaced to the client Signed-off-by: Siddhartha Bingi <[email protected]> * Passing tenantId in Transport Actions Signed-off-by: Siddhartha Bingi <[email protected]> * Updating tests to have tenantId as null for consistency Signed-off-by: Siddhartha Bingi <[email protected]> * Minor code refactoring Signed-off-by: Siddhartha Bingi <[email protected]> --------- Signed-off-by: Siddhartha Bingi <[email protected]> Co-authored-by: Siddhartha Bingi <[email protected]> (cherry picked from commit 055f1ea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jan 23, 2025
Integrate multitenancy into workflow provisioning (#1012) * Adding tenantId in ProcessNode to be surfaced to the client * Passing tenantId in Transport Actions * Updating tests to have tenantId as null for consistency * Minor code refactoring --------- (cherry picked from commit 055f1ea) Signed-off-by: Siddhartha Bingi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddhartha Bingi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass the tenantId in the (de-)(re-)provisioning transport actions to the workflow steps that execute the provisioning, and eventually to the respective client calls.
Related Issues
#987
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.