Fix tests to handle ambiguous mlClient method signature #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
=========================================
Coverage 77.57% 77.57%
Complexity 993 993
=========================================
Files 99 99
Lines 4714 4714
Branches 431 431
=========================================
Hits 3657 3657
Misses 877 877
Partials 180 180 ☔ View full report in Codecov by Sentry. |
junweid62
approved these changes
Jan 15, 2025
owaiskazi19
approved these changes
Jan 15, 2025
src/test/java/org/opensearch/flowframework/workflow/DeleteConnectorStepTests.java
Show resolved
Hide resolved
amitgalitz
approved these changes
Jan 15, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 4b92fb8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jan 15, 2025
#996) Fix tests to handle ambiguous mlClient method signature (#995) (cherry picked from commit 4b92fb8) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following opensearch-project/ml-commons#3382, the ML Client has multiple method signatures matching
deleteConnector(String, Object).Updates tests that were failing due to this ambiguity.
Related Issues
Resolves failing compilation and tests such as https://github.com/opensearch-project/flow-framework/actions/runs/12784028161/job/35636228362
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.