Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly designate model state for actively training models when nodes crash or leave cluster #1317

Merged
merged 40 commits into from
Dec 12, 2023

Merge branch main into model_stuck_train_state

b6b85a9
Select commit
Loading
Failed to load commit list.
Merged

Properly designate model state for actively training models when nodes crash or leave cluster #1317

Merge branch main into model_stuck_train_state
b6b85a9
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch failed Dec 8, 2023 in 0s

76.98% of diff hit (target 85.15%)

View this Pull Request on Codecov

76.98% of diff hit (target 85.15%)

Annotations

Check warning on line 262 in src/main/java/org/opensearch/knn/index/IndexUtil.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/index/IndexUtil.java#L262 

Added line #L262 was not covered by tests

Check warning on line 77 in src/main/java/org/opensearch/knn/indices/ModelMetadata.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/indices/ModelMetadata.java#L77 

Added line #L77 was not covered by tests

Check warning on line 89 in src/main/java/org/opensearch/knn/plugin/transport/TrainingModelTransportAction.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/plugin/transport/TrainingModelTransportAction.java#L89 

Added line #L89 was not covered by tests

Check warning on line 92 in src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java#L91-L92 

Added lines #L91 - L92 were not covered by tests

Check warning on line 102 in src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java#L99-L102 

Added lines #L99 - L102 were not covered by tests

Check warning on line 155 in src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java#L154-L155 

Added lines #L154 - L155 were not covered by tests

Check warning on line 168 in src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java#L167-L168 

Added lines #L167 - L168 were not covered by tests

Check warning on line 173 in src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/training/TrainingJobClusterStateListener.java#L172-L173 

Added lines #L172 - L173 were not covered by tests

Check warning on line 112 in src/main/java/org/opensearch/knn/training/TrainingJobRunner.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/training/TrainingJobRunner.java#L112 

Added line #L112 was not covered by tests

Check warning on line 115 in src/main/java/org/opensearch/knn/training/TrainingJobRunner.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/training/TrainingJobRunner.java#L115 

Added line #L115 was not covered by tests

Check warning on line 136 in src/main/java/org/opensearch/knn/training/TrainingJobRunner.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/training/TrainingJobRunner.java#L136 

Added line #L136 was not covered by tests

Check warning on line 157 in src/main/java/org/opensearch/knn/training/TrainingJobRunner.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/training/TrainingJobRunner.java#L156-L157 

Added lines #L156 - L157 were not covered by tests

Check warning on line 173 in src/main/java/org/opensearch/knn/training/TrainingJobRunner.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/knn/training/TrainingJobRunner.java#L173 

Added line #L173 was not covered by tests
View more details on Codecov