Refactor createParseField function in mappers for code reusability #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
navneet1v
force-pushed
the
main
branch
3 times, most recently
from
eadb951 to
8238028
Compare
Signed-off-by: Navneet Verma <[email protected]>
jmazanec15
approved these changes
May 31, 2024
naveentatikonda
approved these changes
May 31, 2024
naveentatikonda
changed the title
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 31, 2024
…1726) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 623b610)
navneet1v
added a commit
that referenced
this pull request
Jun 7, 2024
…1726) (#1727) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 623b610) Co-authored-by: Navneet Verma <[email protected]>
shatejas
pushed a commit
to shatejas/k-NN
that referenced
this pull request
Jun 26, 2024
…pensearch-project#1726) Signed-off-by: Navneet Verma <[email protected]>
luyuncheng
pushed a commit
to luyuncheng/k-NN-1
that referenced
this pull request
Jul 7, 2024
…pensearch-project#1726) Signed-off-by: Navneet Verma <[email protected]>
luyuncheng
pushed a commit
to luyuncheng/k-NN-1
that referenced
this pull request
Jul 7, 2024
…pensearch-project#1726) Signed-off-by: Navneet Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refractor createParseField function in mappers for code reusability.
I added 2 functions for creating all the indexable fields required for floats and then same for byte vector too. These functions can be overriden by the individual mappers if needed. Lucene Fields Mapper overrides them
Issues Resolved
#1632
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.