Adds integration tests for NativeEngineKnnVectorsFormat code path #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shatejas
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
shatejas
force-pushed
the
integ-test
branch
3 times, most recently
from
5bacaa7 to
995b8f2
Compare
navneet1v
reviewed
Aug 28, 2024
Comment on lines
+84
to
85
| final KNNMethodContext knnMethodContext = extractKNNMethodContext(mappedFieldType); | ||
| final Map<String, Object> params = knnMethodContext.getMethodComponentContext().getParameters(); |
There was a problem hiding this comment.
final Map<String, Object> params = knnMethodContext.getMethodComponentContext().getParameters()
getMethodComponentContext here can be null. We need to build this getMethodComponentContext from scratch. See BWC tests are failing.
There was a problem hiding this comment.
cc: @jmazanec15 , @shatejas
Signed-off-by: Tejas Shah <[email protected]>
shatejas
force-pushed
the
integ-test
branch
2 times, most recently
from
c910981 to
02418b5
Compare
|
Closing in favor of #2020 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds integration test for #1950
This also turns on the flag to use native index writer
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.