-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mute testKNNWarmupCustomLegacyFieldMapping #2416
Merged
navneet1v
merged 1 commit into
opensearch-project:main
from
kotwanikunal:mute-legacy-mapper-warmup
Jan 22, 2025
Merged
Mute testKNNWarmupCustomLegacyFieldMapping #2416
navneet1v
merged 1 commit into
opensearch-project:main
from
kotwanikunal:mute-legacy-mapper-warmup
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kunal Kotwani <[email protected]>
kotwanikunal
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
January 22, 2025 21:02
waiting for CIs to complete |
jmazanec15
approved these changes
Jan 22, 2025
jmazanec15
reviewed
Jan 22, 2025
@@ -46,6 +46,7 @@ public void testKNNWarmupDefaultLegacyFieldMapping() throws Exception { | |||
|
|||
// Custom Legacy Field Mapping | |||
// space_type : "innerproduct", engine : "nmslib", m : 2, ef_construction : 2 | |||
@AwaitsFix(bugUrl = "https://github.com/opensearch-project/k-NN/issues/2415") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thats cool!
navneet1v
approved these changes
Jan 22, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit f11bd9f)
e-emoto
pushed a commit
to e-emoto/k-NN
that referenced
this pull request
Jan 22, 2025
Signed-off-by: Kunal Kotwani <[email protected]>
e-emoto
pushed a commit
to e-emoto/k-NN
that referenced
this pull request
Jan 22, 2025
Signed-off-by: Kunal Kotwani <[email protected]>
navneet1v
pushed a commit
that referenced
this pull request
Jan 23, 2025
Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit f11bd9f) Co-authored-by: Kunal Kotwani <[email protected]>
navneet1v
pushed a commit
that referenced
this pull request
Jan 23, 2025
…th knn_vector field (#2411) * Add support for search using the "fields" parameter with knn_vector field (#2314) Signed-off-by: Ethan Emoto <[email protected]> Signed-off-by: Ethan Emoto <[email protected]> (cherry picked from commit 5c63fde) * Fix NPE in backporting fields parameter ITs Signed-off-by: Ethan Emoto <[email protected]> * Mute testKNNWarmupCustomLegacyFieldMapping (#2416) Signed-off-by: Kunal Kotwani <[email protected]> --------- Signed-off-by: Ethan Emoto <[email protected]> Signed-off-by: Kunal Kotwani <[email protected]> Co-authored-by: Kunal Kotwani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
testKNNWarmupCustomLegacyFieldMapping
after confirmation with the test author on the impactRelated Issues
Mutes #2415
Check List
New functionality includes testing.New functionality has been documented.API changes companion pull request created.--signoff
.Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.