Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute testKNNWarmupCustomLegacyFieldMapping #2416

Merged

Conversation

kotwanikunal
Copy link
Member

Description

  • Mutes testKNNWarmupCustomLegacyFieldMapping after confirmation with the test author on the impact
  • Re-running the test with the same seed is unable to reproduce the issue
  • RCA is taking longer - unblocking the CI/merges for 2.19 in the meanwhile

Related Issues

Mutes #2415

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v
Copy link
Collaborator

waiting for CIs to complete

@@ -46,6 +46,7 @@ public void testKNNWarmupDefaultLegacyFieldMapping() throws Exception {

// Custom Legacy Field Mapping
// space_type : "innerproduct", engine : "nmslib", m : 2, ef_construction : 2
@AwaitsFix(bugUrl = "https://github.com/opensearch-project/k-NN/issues/2415")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thats cool!

@navneet1v navneet1v merged commit f11bd9f into opensearch-project:main Jan 22, 2025
30 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 22, 2025
Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit f11bd9f)
e-emoto pushed a commit to e-emoto/k-NN that referenced this pull request Jan 22, 2025
e-emoto pushed a commit to e-emoto/k-NN that referenced this pull request Jan 22, 2025
navneet1v pushed a commit that referenced this pull request Jan 23, 2025
Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit f11bd9f)

Co-authored-by: Kunal Kotwani <[email protected]>
navneet1v pushed a commit that referenced this pull request Jan 23, 2025
…th knn_vector field (#2411)

* Add support for search using the "fields" parameter with knn_vector field (#2314)

Signed-off-by: Ethan Emoto <[email protected]>
Signed-off-by: Ethan Emoto <[email protected]>
(cherry picked from commit 5c63fde)

* Fix NPE in backporting fields parameter ITs

Signed-off-by: Ethan Emoto <[email protected]>

* Mute testKNNWarmupCustomLegacyFieldMapping (#2416)

Signed-off-by: Kunal Kotwani <[email protected]>

---------

Signed-off-by: Ethan Emoto <[email protected]>
Signed-off-by: Kunal Kotwani <[email protected]>
Co-authored-by: Kunal Kotwani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants