Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix that fixes AVX512SPR build #2446

Closed

Conversation

akashsha1
Copy link
Contributor

Remove an AND from avx512spr check, which causes the k-nn build to fail when running on an Intel Sapphire Rapids machine.

Description

[Describe what this change achieves]
Fix a bug that was failing AVX512SPR builds.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Remove an AND from avx512spr check.

Signed-off-by: akashsha1 <[email protected]>
@naveentatikonda
Copy link
Member

naveentatikonda commented Jan 27, 2025

@akashsha1 can you raise this PR to 2.x and then backport to main. The CI on main is broken and it will take time to fix it. This needs to be fixed but I didn't run into any issue while building on r7i instance. Did your build broke ?

@akashsha1
Copy link
Contributor Author

@akashsha1 can you raise this PR to 2.x and then backport to main. The CI on main is broken and it will take time to fix it. This needs to be fixed but I didn't run into any issue while building on r7i instance. Did your build broke ?

Looks like the avx512spr change has not made it to the 2.x branch yet, so I cannot make this update there.
Yeah, I ran into a CMake error on my SPR (r7i) machine when attempting to build avx512spr faiss.

@naveentatikonda
Copy link
Member

Looks like the avx512spr change has not made it to the 2.x branch yet, so I cannot make this update there. Yeah, I ran into a CMake error on my SPR (r7i) machine when attempting to build avx512spr faiss.

Yeah you are right. Let me fix it in 2.x PR

@navneet1v
Copy link
Collaborator

@akashsha1 the similar PR is created by @sam-herman here: #2442

@akashsha1
Copy link
Contributor Author

@akashsha1 the similar PR is created by @sam-herman here: #2442

Good catch. its the same fix. This PR can be closed in favor of the other change then.

@akashsha1 akashsha1 closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants