Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set gcc version lock on x64 and arm64 for avx512_spr support #2457

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Properly set gcc version lock on x64 and arm64 for avx512_spr support

Related Issues

opensearch-project/opensearch-build#5152
Closes opensearch-project/opensearch-build#5226

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon merged commit 612c3b5 into opensearch-project:main Jan 28, 2025
17 of 34 checks passed
@peterzhuamazon peterzhuamazon deleted the gcc-version-setups branch January 28, 2025 01:32
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2457-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 612c3b59e057b342506d416045f567cc483fdbd7
# Push it to GitHub
git push --set-upstream origin backport/backport-2457-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2457-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Bug Fixes Changes to a system or product designed to handle a programming bug/glitch Enhancements Increases software capabilities beyond original client specifications release skip-changelog v2.19.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Bump up GCC version to 12.x or later to support SIMD AVX512 fp16 instructions
3 participants