Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update engine for version 2.19 or above #2501

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

VijayanB
Copy link
Member

@VijayanB VijayanB commented Feb 6, 2025

Description

We changed default engine from NMSLIB to FAISS on 2.18. Hence, for use case where mode is not configured and compression is 1x or undefined we default to nmslib since cosine similarity was not supported. From 2.19, we added support to cosine, so, we can now change it to faiss for no compression or 1x compression to align with our strategy on deprecating nmslib in future releases.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VijayanB
Copy link
Member Author

VijayanB commented Feb 6, 2025

Added this PR directly to release note and added skip change log

@VijayanB
Copy link
Member Author

VijayanB commented Feb 6, 2025

@naveentatikonda looks like integration test is crashing cluster. is this related to gcc issue? This is only happening for linux CI

@naveentatikonda
Copy link
Member

@naveentatikonda looks like integration test is crashing cluster. is this related to gcc issue? This is only happening for linux CI

Yes, looks like that. Peter is working on making the changes to image which will build nmslib using gcc-10

@VijayanB VijayanB merged commit 8ee82b9 into opensearch-project:2.19 Feb 6, 2025
97 of 102 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2025
Signed-off-by: Balasubramanian <[email protected]>
(cherry picked from commit 8ee82b9)
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-2501-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ee82b9528de4767ffa7bf96f1e51d5895761db7
# Push it to GitHub
git push --set-upstream origin backport/backport-2501-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-2501-to-main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants