Introduce node level circuit breaker settings for k-NN #2507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KNN plugin currently uses a cluster-wide circuit breaker. This doesn't work as well as it could when nodes have different memory capacities.
Solution
Added node-specific circuit breaker limits using node attributes. This opens up flexibility for heterogenous circuit breaker limits.
Usage
opensearch.yml
:Implementation
groupSetting
for dynamic limit configurationsTesting
Modified KNNCircuitBreakerIT integration tests to include node-level CB.
Used OSB benchmarking to run a modified low load test with/without the node level circuit breaker.
node.attr.knn_cb_tier = 'integ'
to build.gradleInitial state (no limits set):
After setting node limit to 500000kb:
Setting cluster limit to 5kb didn't affect node with specific limit which confirms proper override behavior.
Related Issues
Resolves #2263
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.