fine tune predict API: read model from index directly #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
wujunshen,
zane-neo and
Zhangxunmt
as code owners
Zhangxunmt
approved these changes
Oct 27, 2023
dhrubo-os
reviewed
Oct 27, 2023
| @@ -109,8 +105,9 @@ public RestChannelConsumer prepareRequest(RestRequest request, NodeClient client | |||
| log.error("Failed to send error response", ex); | |||
| } | |||
| }); | |||
| client.execute(MLModelGetAction.INSTANCE, getModelRequest, listener); | |||
|
|
|||
| try (ThreadContext.StoredContext context = client.threadPool().getThreadContext().stashContext()) { | |||
There was a problem hiding this comment.
why do we need stashContext here?
There was a problem hiding this comment.
model index is system index
rbhavna
approved these changes
Oct 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #1557 +/- ##
============================================
+ Coverage 78.39% 78.42% +0.02%
- Complexity 2378 2380 +2
============================================
Files 195 195
Lines 9594 9593 -1
Branches 964 964
============================================
+ Hits 7521 7523 +2
+ Misses 1636 1632 -4
- Partials 437 438 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 0920ba7)
ylwu-amzn
added a commit
that referenced
this pull request
Oct 27, 2023
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 0920ba7) Co-authored-by: Yaliang Wu <[email protected]>
TrungBui59
pushed a commit
to TrungBui59/ml-commons
that referenced
this pull request
Nov 6, 2023
…ject#1557) Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: TrungBui59 <[email protected]>
TrungBui59
pushed a commit
to TrungBui59/ml-commons
that referenced
this pull request
Nov 6, 2023
…ject#1557) Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: TrungBui59 <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Feb 29, 2024
…ject#1557) Signed-off-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User needs both get model and predict permission for predict API. That's not reasonable.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.