Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix register client API #1560

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix register client API #1560

merged 1 commit into from
Oct 27, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

@ylwu-amzn ylwu-amzn commented Oct 27, 2023

Description

Read more details : #1553

Issues Resolved

Resolve #1553

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <[email protected]>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 27, 2023 06:13 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 27, 2023 06:13 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 27, 2023 06:13 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1560 (c977acf) into main (0920ba7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1560   +/-   ##
=========================================
  Coverage     78.40%   78.40%           
- Complexity     2378     2380    +2     
=========================================
  Files           195      195           
  Lines          9593     9595    +2     
  Branches        964      964           
=========================================
+ Hits           7521     7523    +2     
  Misses         1635     1635           
  Partials        437      437           
Flag Coverage Δ
ml-commons 78.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pensearch/ml/client/MachineLearningNodeClient.java 98.18% <100.00%> (+0.03%) ⬆️

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 27, 2023 07:00 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 27, 2023 07:00 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 27, 2023 07:00 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn marked this pull request as ready for review October 27, 2023 07:01
@ylwu-amzn ylwu-amzn merged commit 713dcba into opensearch-project:main Oct 27, 2023
8 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 27, 2023
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 713dcba)
ylwu-amzn added a commit that referenced this pull request Oct 27, 2023
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 713dcba)

Co-authored-by: Yaliang Wu <[email protected]>
@opensearch-trigger-bot
Copy link
Contributor

The backport to feature/agent_framework_dev failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-feature/agent_framework_dev feature/agent_framework_dev
# Navigate to the new working tree
cd .worktrees/backport-feature/agent_framework_dev
# Create a new branch
git switch --create backport/backport-1560-to-feature/agent_framework_dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 713dcba9f843b6fb1bb23dcb88973373371ea8df
# Push it to GitHub
git push --set-upstream origin backport/backport-1560-to-feature/agent_framework_dev
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-feature/agent_framework_dev

Then, create a pull request where the base branch is feature/agent_framework_dev and the compare/head branch is backport/backport-1560-to-feature/agent_framework_dev.

TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 6, 2023
Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 6, 2023
Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Class Cast Exception when invoking Register API through MLClient
4 participants