Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] update default model_access_mode for model group #1594

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

rawwar
Copy link
Contributor

@rawwar rawwar commented Nov 4, 2023

Description

I see that when I create model group without mentioning model_access_mode, it is defaulting to private and not restricted.

Model Group creation:
image

Model group information:

{
  "took": 1,
  "timed_out": false,
  "_shards": {
    "total": 1,
    "successful": 1,
    "skipped": 0,
    "failed": 0
  },
  "hits": {
    "total": {
      "value": 1,
      "relation": "eq"
    },
    "max_score": 1.540445,
    "hits": [
      {
        "_index": ".plugins-ml-model-group",
        "_id": "ARQBmosBbA7S7gCnC1jL",
        "_version": 1,
        "_seq_no": 16,
        "_primary_term": 1,
        "_score": 1.540445,
        "_source": {
          "owner": {
            "backend_roles": [
              "admin"
            ],
            "custom_attribute_names": [],
            "roles": [
              "own_index",
              "all_access"
            ],
            "name": "admin",
            "user_requested_tenant": null
          },
          "created_time": 1699095841739,
          "access": "private",
          "latest_version": 0,
          "last_updated_time": 1699095841739,
          "name": "test111",
          "description": "This is a test model group"
        }
      }
    ]
  }
}

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os
Copy link
Collaborator

@rbhavna Could you please review this PR? Thanks.

@rbhavna
Copy link
Collaborator

rbhavna commented Nov 7, 2023

yes it is expected. The default it private: https://opensearch.org/docs/latest/ml-commons-plugin/model-access-control/#registering-a-private-model-group

@rawwar
Copy link
Contributor Author

rawwar commented Nov 8, 2023

yes it is expected. The default it private: https://opensearch.org/docs/latest/ml-commons-plugin/model-access-control/#registering-a-private-model-group

Thanks for confirming. So, we can merge the PR? @dhrubo-os , @rbhavna

@dhrubo-os dhrubo-os merged commit bfd53bc into opensearch-project:main Nov 22, 2023
6 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Kalyan <[email protected]>
(cherry picked from commit bfd53bc)
ylwu-amzn pushed a commit that referenced this pull request Nov 23, 2023
Signed-off-by: Kalyan <[email protected]>
(cherry picked from commit bfd53bc)

Co-authored-by: Kalyan <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x documentation Improvements or additions to documentation
Projects
Status: Planned work items
Development

Successfully merging this pull request may close these issues.

3 participants