Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register agent API support for MLClient #1656

Conversation

arjunkumargiri
Copy link
Contributor

@arjunkumargiri arjunkumargiri commented Nov 17, 2023

Description

Register agent API support for MLClient. This will allow flow framework to integrate with register agent API.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Arjun kumar Giri <[email protected]>

Addressed feedback

Signed-off-by: Arjun kumar Giri <[email protected]>

Ignore flaky integration test

Signed-off-by: Arjun kumar Giri <[email protected]>
Signed-off-by: Arjun kumar Giri <[email protected]>
Signed-off-by: Arjun kumar Giri <[email protected]>
.execute(
MLRegisterAgentAction.INSTANCE,
mlRegisterAgentRequest,
ActionListener.wrap(listener::onResponse, listener::onFailure)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ActionListener.wrap(listener::onResponse, listener::onFailure)
getMLRegisterAgentResponseActionListener(listener)

@ylwu-amzn ylwu-amzn merged commit ec987da into opensearch-project:feature/agent_framework_dev Nov 17, 2023
@owaiskazi19
Copy link
Member

owaiskazi19 commented Nov 17, 2023

@ylwu-amzn the above change is needed or else it will fail with ClassCastException. Let me raise a PR

@ylwu-amzn
Copy link
Collaborator

@ylwu-amzn the above change is needed or else it will fail with ClassCastException. Let me raise a PR

Sure, thanks @owaiskazi19

@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-1656-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ec987da5903fb44fc80c96bccc53c77ae823738a
# Push it to GitHub
git push --set-upstream origin backport/backport-1656-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-1656-to-main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants