-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register agent API support for MLClient #1656
Register agent API support for MLClient #1656
Conversation
Signed-off-by: Arjun kumar Giri <[email protected]> Addressed feedback Signed-off-by: Arjun kumar Giri <[email protected]> Ignore flaky integration test Signed-off-by: Arjun kumar Giri <[email protected]>
4cd2657
to
a91d7c1
Compare
Signed-off-by: Arjun kumar Giri <[email protected]>
Signed-off-by: Arjun kumar Giri <[email protected]>
a91d7c1
to
5175dac
Compare
69f888c
to
3f15e4c
Compare
0d8768d
to
a891de1
Compare
a891de1
to
00ab54f
Compare
00ab54f
to
14732ee
Compare
Signed-off-by: Arjun kumar Giri <[email protected]>
14732ee
to
20758ae
Compare
.execute( | ||
MLRegisterAgentAction.INSTANCE, | ||
mlRegisterAgentRequest, | ||
ActionListener.wrap(listener::onResponse, listener::onFailure) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ActionListener.wrap(listener::onResponse, listener::onFailure) | |
getMLRegisterAgentResponseActionListener(listener) |
@ylwu-amzn the above change is needed or else it will fail with ClassCastException. Let me raise a PR |
Sure, thanks @owaiskazi19 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-1656-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ec987da5903fb44fc80c96bccc53c77ae823738a
# Push it to GitHub
git push --set-upstream origin backport/backport-1656-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main Then, create a pull request where the |
Description
Register agent API support for MLClient. This will allow flow framework to integrate with register agent API.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.