Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/agent_framework_dev] Add and apply spotless to ml-algorithms package #1671

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Nov 21, 2023

Description

Forward port #1610 to dev branch. Manually re-added and re-ran so all current files in this package of the dev branch have been updated.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler temporarily deployed to ml-commons-cicd-env November 21, 2023 22:35 — with GitHub Actions Inactive
@ohltyler ohltyler temporarily deployed to ml-commons-cicd-env November 21, 2023 22:35 — with GitHub Actions Inactive
@ohltyler ohltyler changed the title Add and apply spotless to ml-algorithms package [feature/agent_framework_dev] Add and apply spotless to ml-algorithms package Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 455 lines in your changes are missing coverage. Please review.

Comparison is base (30c2294) 67.26% compared to head (0aa800c) 66.48%.

Files Patch % Lines
.../ml/engine/algorithms/agent/MLChatAgentRunner.java 0.00% 186 Missing ⚠️
...ml/engine/algorithms/agent/MLReActAgentRunner.java 45.31% 68 Missing and 2 partials ⚠️
...rithms/metrics_correlation/MetricsCorrelation.java 14.00% 41 Missing and 2 partials ⚠️
...arch/ml/engine/memory/ConversationIndexMemory.java 0.00% 26 Missing ⚠️
...a/org/opensearch/ml/engine/tools/VectorDBTool.java 0.00% 26 Missing ⚠️
...g/opensearch/ml/engine/memory/MLMemoryManager.java 0.00% 21 Missing ⚠️
...ch/ml/engine/algorithms/agent/MLAgentExecutor.java 0.00% 11 Missing ⚠️
...java/org/opensearch/ml/engine/tools/AgentTool.java 0.00% 11 Missing ⚠️
.../ml/engine/algorithms/clustering/RCFSummarize.java 78.94% 7 Missing and 1 partial ⚠️
...ain/java/org/opensearch/ml/engine/ModelHelper.java 78.26% 4 Missing and 1 partial ⚠️
... and 22 more
Additional details and impacted files
@@                        Coverage Diff                        @@
##             feature/agent_framework_dev    #1671      +/-   ##
=================================================================
- Coverage                          67.26%   66.48%   -0.79%     
- Complexity                          2520     2521       +1     
=================================================================
  Files                                231      231              
  Lines                              12285    12554     +269     
  Branches                            1264     1268       +4     
=================================================================
+ Hits                                8263     8346      +83     
- Misses                              3469     3654     +185     
- Partials                             553      554       +1     
Flag Coverage Δ
ml-commons 66.48% <51.69%> (-0.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ylwu-amzn ylwu-amzn merged commit becfbe0 into opensearch-project:feature/agent_framework_dev Nov 21, 2023
4 of 7 checks passed
@ohltyler ohltyler deleted the spotless-dev branch November 21, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants