-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separate get Trace actions into a new rest API #1672
separate get Trace actions into a new rest API #1672
Conversation
Signed-off-by: Xun Zhang <[email protected]>
/** Instance of this */ | ||
public static final GetTracesAction INSTANCE = new GetTracesAction(); | ||
/** Name of this action */ | ||
public static final String NAME = "cluster:admin/opensearch/ml/memory/trace/get"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trace is only for conversation agent, to make it general, maybe build a general search API for interaction data ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The general search API already exists. This "get trace" is only meant for the conversation agent to let FE use. The "list interaction" will only return interactions that have "null" trace_number (final response). In other agents, the "list interactions" API still works to list all interactions because the "trace_number" is null since it's only used in the conversational context.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/agent_framework_dev #1672 +/- ##
=================================================================
- Coverage 66.46% 66.42% -0.04%
- Complexity 2520 2521 +1
=================================================================
Files 231 232 +1
Lines 12554 12560 +6
Branches 1268 1268
=================================================================
- Hits 8344 8343 -1
- Misses 3657 3663 +6
- Partials 553 554 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8e36de3
into
opensearch-project:feature/agent_framework_dev
Description
Only return final results in the "List Conversation" API. Add a new API of "Get Trace" to return only traces for an interaction.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.