Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport multiple PRs to 2.x from main #1705

Merged
merged 7 commits into from
Nov 28, 2023

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Nov 28, 2023

Description

Backporting below PRs to 2.x from main:
#1250
#1278
#1409
#1579
#1610
#1670

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ylwu-amzn and others added 7 commits November 25, 2023 01:47
Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
…ect#1278)

* Fix missing lombok version compilation failure issue

Signed-off-by: zane-neo <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
* Get model group API

Signed-off-by: Bhavana Ramaram <[email protected]>
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 28, 2023 20:14 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 28, 2023 20:14 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 28, 2023 20:28 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 28, 2023 20:28 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 28, 2023 20:54 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 28, 2023 20:54 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env November 28, 2023 21:35 — with GitHub Actions Failure
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env November 28, 2023 21:35 — with GitHub Actions Inactive
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (df5e065) 80.77% compared to head (acac60f) 80.76%.

Files Patch % Lines
...rithms/metrics_correlation/MetricsCorrelation.java 14.00% 41 Missing and 2 partials ⚠️
.../ml/engine/algorithms/clustering/RCFSummarize.java 78.94% 7 Missing and 1 partial ⚠️
...tion/model_group/GetModelGroupTransportAction.java 84.09% 6 Missing and 1 partial ⚠️
...ain/java/org/opensearch/ml/engine/ModelHelper.java 66.66% 4 Missing and 1 partial ⚠️
...ch/ml/engine/algorithms/remote/ConnectorUtils.java 68.75% 2 Missing and 3 partials ⚠️
..._embedding/HuggingfaceTextEmbeddingTranslator.java 33.33% 4 Missing ⚠️
...gine/algorithms/tokenize/SparseTokenizerModel.java 78.57% 2 Missing and 1 partial ⚠️
...n/transport/model_group/MLModelGroupGetAction.java 0.00% 2 Missing ⚠️
...l/engine/algorithms/ad/AnomalyDetectionLibSVM.java 87.50% 0 Missing and 2 partials ⚠️
...thms/anomalylocalization/AnomalyLocalizerImpl.java 96.66% 0 Missing and 2 partials ⚠️
... and 12 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1705      +/-   ##
============================================
- Coverage     80.77%   80.76%   -0.01%     
- Complexity     4188     4216      +28     
============================================
  Files           399      404       +5     
  Lines         16845    16994     +149     
  Branches       1816     1819       +3     
============================================
+ Hits          13607    13726     +119     
- Misses         2524     2552      +28     
- Partials        714      716       +2     
Flag Coverage Δ
ml-commons 80.76% <83.84%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhrubo-os dhrubo-os merged commit 5ac7d6a into opensearch-project:2.x Nov 28, 2023
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants