-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cohere version 3 embedding model #1721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
austintlee and
HenryL27
as code owners
December 1, 2023 02:28
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
December 1, 2023 02:28 — with
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
December 1, 2023 02:28 — with
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
December 1, 2023 02:28 — with
GitHub Actions
Error
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
December 1, 2023 02:28 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
December 1, 2023 02:28 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
December 1, 2023 02:28 — with
GitHub Actions
Inactive
zane-neo
approved these changes
Dec 1, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1721 +/- ##
============================================
- Coverage 80.82% 80.81% -0.02%
+ Complexity 4220 4218 -2
============================================
Files 404 404
Lines 16994 17000 +6
Branches 1819 1819
============================================
+ Hits 13736 13739 +3
- Misses 2545 2548 +3
Partials 713 713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
December 1, 2023 02:48 — with
GitHub Actions
Failure
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
December 1, 2023 02:48 — with
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
December 1, 2023 02:48 — with
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Dec 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit b131f1e)
ylwu-amzn
pushed a commit
that referenced
this pull request
Dec 1, 2023
Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit b131f1e) Co-authored-by: Xun Zhang <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Feb 29, 2024
…earch-project#1723) Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit b131f1e) Co-authored-by: Xun Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per request from Cohere, add the cohere v3.0 embedding model blueprint. The previous blueprint is renamed to v2.0.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.