Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cohere version 3 embedding model #1721

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Zhangxunmt
Copy link
Collaborator

Description

Per request from Cohere, add the cohere v3.0 embedding model blueprint. The previous blueprint is renamed to v2.0.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f46d258) 80.82% compared to head (5baebbb) 80.81%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1721      +/-   ##
============================================
- Coverage     80.82%   80.81%   -0.02%     
+ Complexity     4220     4218       -2     
============================================
  Files           404      404              
  Lines         16994    17000       +6     
  Branches       1819     1819              
============================================
+ Hits          13736    13739       +3     
- Misses         2545     2548       +3     
  Partials        713      713              
Flag Coverage Δ
ml-commons 80.81% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env December 1, 2023 02:48 — with GitHub Actions Inactive
@Zhangxunmt Zhangxunmt temporarily deployed to ml-commons-cicd-env December 1, 2023 02:48 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit b131f1e into opensearch-project:2.x Dec 1, 2023
12 of 16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 1, 2023
Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit b131f1e)
ylwu-amzn pushed a commit that referenced this pull request Dec 1, 2023
Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit b131f1e)

Co-authored-by: Xun Zhang <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants