Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PRs from 2.11 to main #1726

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Dec 1, 2023

Description

Backporting #1586 and #1587 from 2.11 to main

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…pensearch-project#1586)

* support step size for embedding model which outputs less embeddings

Signed-off-by: Yaliang Wu <[email protected]>

* tune parameter name

Signed-off-by: Yaliang Wu <[email protected]>

* fine tune processed doc to always respect step size

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env December 1, 2023 06:59 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env December 1, 2023 07:00 — with GitHub Actions Failure
@rbhavna rbhavna force-pushed the backport_from_2.11 branch from b5b05ee to bc0c223 Compare December 1, 2023 07:02
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env December 1, 2023 07:03 — with GitHub Actions Failure
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env December 1, 2023 07:03 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env December 1, 2023 07:03 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env December 1, 2023 07:03 — with GitHub Actions Inactive
@rbhavna rbhavna force-pushed the backport_from_2.11 branch from bc0c223 to 060bcab Compare December 1, 2023 07:16
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env December 1, 2023 07:16 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env December 1, 2023 07:16 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env December 1, 2023 07:16 — with GitHub Actions Failure
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adc7da0) 81.22% compared to head (d4da21d) 81.21%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1726      +/-   ##
============================================
- Coverage     81.22%   81.21%   -0.01%     
+ Complexity     4339     4338       -1     
============================================
  Files           421      421              
  Lines         17303    17310       +7     
  Branches       1829     1831       +2     
============================================
+ Hits          14054    14058       +4     
- Misses         2531     2534       +3     
  Partials        718      718              
Flag Coverage Δ
ml-commons 81.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbhavna rbhavna force-pushed the backport_from_2.11 branch from 060bcab to d4da21d Compare December 1, 2023 07:21
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env December 1, 2023 07:21 — with GitHub Actions Failure
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env December 1, 2023 07:22 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env December 1, 2023 07:22 — with GitHub Actions Inactive
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env December 1, 2023 07:22 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env December 1, 2023 07:58 — with GitHub Actions Failure
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env December 1, 2023 07:58 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env December 1, 2023 07:58 — with GitHub Actions Inactive
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env December 1, 2023 07:59 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn merged commit 6fe7222 into opensearch-project:main Dec 1, 2023
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants