Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delete Agent to MLClient #1731

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Dec 3, 2023

Description

Adds MLClient method for delete agent.

Similar to Delete Connector and Delete Model (literally a copy/paste/change-names), does not require special treatment of the response class loader.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Daniel Widdis <[email protected]>
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb86968) 68.60% compared to head (d920a45) 68.59%.

Additional details and impacted files
@@                        Coverage Diff                        @@
##             feature/agent_framework_dev    #1731      +/-   ##
=================================================================
- Coverage                          68.60%   68.59%   -0.02%     
- Complexity                          2591     2592       +1     
=================================================================
  Files                                239      239              
  Lines                              12757    12765       +8     
  Branches                            1284     1284              
=================================================================
+ Hits                                8752     8756       +4     
- Misses                              3404     3407       +3     
- Partials                             601      602       +1     
Flag Coverage Δ
ml-commons 68.59% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ylwu-amzn ylwu-amzn merged commit 8bda65a into opensearch-project:feature/agent_framework_dev Dec 4, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants