fix flaky test due to localization #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
force-pushed
the
fix_flaky_test
branch
from
0657a90 to
094a4d6
Compare
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/agent_framework_dev #1734 +/- ##
=================================================================
+ Coverage 68.60% 68.96% +0.36%
- Complexity 2591 2608 +17
=================================================================
Files 239 241 +2
Lines 12757 12815 +58
Branches 1284 1288 +4
=================================================================
+ Hits 8752 8838 +86
+ Misses 3404 3373 -31
- Partials 601 604 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@ylwu-amzn @Zhangxunmt please help to review |
dhrubo-os
approved these changes
Dec 5, 2023
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
approved these changes
Dec 5, 2023
ylwu-amzn
reviewed
Dec 5, 2023
| @@ -68,7 +68,8 @@ public String encrypt(String plainText) { | |||
| initMasterKey(); | |||
| final AwsCrypto crypto = AwsCrypto.builder().withCommitmentPolicy(CommitmentPolicy.RequireEncryptRequireDecrypt).build(); | |||
| byte[] bytes = Base64.getDecoder().decode(masterKey); | |||
| JceMasterKey jceMasterKey = JceMasterKey.getInstance(new SecretKeySpec(bytes, "AES"), "Custom", "", "AES/GCM/NoPadding"); | |||
| // https://github.com/aws/aws-encryption-sdk-java/issues/1879 | |||
| JceMasterKey jceMasterKey = JceMasterKey.getInstance(new SecretKeySpec(bytes, "AES"), "Custom", "", "AES/GCM/NOPADDING"); | |||
There was a problem hiding this comment.
Will this break BWC ?
No, the string is uppercased by the method being called. We are just preemptively uppercasing to avoid the wrong uppercase I in Turkish locale.
ylwu-amzn
approved these changes
Dec 5, 2023
ylwu-amzn
merged commit 2299969
into
opensearch-project:feature/agent_framework_dev
4 of 7 checks passed
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI run with locale
-Dtests.locale=tr -Dtests.timezone=Cubahttps://github.com/opensearch-project/ml-commons/actions/runs/7097212068/job/19316954587?pr=1733related to aws/aws-encryption-sdk-java#1879
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.