Get and delete agent APIs #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingshl
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
reviewed
Dec 14, 2023
Signed-off-by: Bhavana Ramaram <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
mingshl
force-pushed
the
main-mingshl
branch
from
5a12d36 to
418ab64
Compare
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
mingshl
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
mingshl
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
reviewed
Dec 16, 2023
common/src/main/java/org/opensearch/ml/common/transport/agent/MLAgentDeleteRequest.java
Show resolved
Hide resolved
common/src/main/java/org/opensearch/ml/common/transport/agent/MLAgentGetRequest.java
Show resolved
Hide resolved
common/src/main/java/org/opensearch/ml/common/transport/agent/MLAgentGetResponse.java
Show resolved
Hide resolved
ylwu-amzn
approved these changes
Dec 16, 2023
|
Don't have major concern. Code coverage is not enough, please add more unit test. |
dhrubo-os
approved these changes
Dec 16, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
* get and delete agent APIs (#1703) Signed-off-by: Bhavana Ramaram <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> * Add unit tests for Get and Delete APIs Signed-off-by: Mingshi Liu <[email protected]> * Add header and increase code coverage Signed-off-by: Mingshi Liu <[email protected]> * change IndexNotFoundException error message Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Bhavana Ramaram <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 4d8d32e)
mingshl
added a commit
that referenced
this pull request
Dec 18, 2023
* get and delete agent APIs (#1703) Signed-off-by: Bhavana Ramaram <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> * Add unit tests for Get and Delete APIs Signed-off-by: Mingshi Liu <[email protected]> * Add header and increase code coverage Signed-off-by: Mingshi Liu <[email protected]> * change IndexNotFoundException error message Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Bhavana Ramaram <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 4d8d32e) Co-authored-by: Mingshi Liu <[email protected]>
Added in #1791 |
jackiehanyang
pushed a commit
to jackiehanyang/ml-commons
that referenced
this pull request
Dec 28, 2023
* get and delete agent APIs (opensearch-project#1703) Signed-off-by: Bhavana Ramaram <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> * Add unit tests for Get and Delete APIs Signed-off-by: Mingshi Liu <[email protected]> * Add header and increase code coverage Signed-off-by: Mingshi Liu <[email protected]> * change IndexNotFoundException error message Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Bhavana Ramaram <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Feb 29, 2024
* get and delete agent APIs (opensearch-project#1703) Signed-off-by: Bhavana Ramaram <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> * Add unit tests for Get and Delete APIs Signed-off-by: Mingshi Liu <[email protected]> * Add header and increase code coverage Signed-off-by: Mingshi Liu <[email protected]> * change IndexNotFoundException error message Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Bhavana Ramaram <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get and Delete Agent APIs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.