Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stash thread context when indexing agent configuration #1767

Conversation

arjunkumargiri
Copy link
Contributor

Description

Create agent with security plugin enabled results in 'no permission' error.

OpenSearch error log

[2023-12-13T16:21:02,446][WARN ][o.o.s.p.SecurityIndexAccessEvaluator] [90a57bde9d1b8d1c093c795895547181] indices:data/write/index for '.plugins-ml-agent' index is not allow
ed for a regular user
[2023-12-13T16:21:02,448][ERROR][o.o.m.a.a.TransportRegisterAgentAction] [90a57bde9d1b8d1c093c795895547181] Failed to index ML agent

Stashed thread context while writing to index. Validated change by deploying to local opensearch server

Issues Resolved

[Create agent with security plugin enabled results in 'no permission']

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (45af778) 68.53% compared to head (8ff05cc) 68.46%.
Report is 1 commits behind head on feature/agent_framework_dev.

Files Patch % Lines
...ml/action/agents/TransportRegisterAgentAction.java 0.00% 13 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##             feature/agent_framework_dev    #1767      +/-   ##
=================================================================
- Coverage                          68.53%   68.46%   -0.07%     
+ Complexity                          2622     2619       -3     
=================================================================
  Files                                242      242              
  Lines                              13010    13016       +6     
  Branches                            1307     1307              
=================================================================
- Hits                                8916     8912       -4     
- Misses                              3484     3494      +10     
  Partials                             610      610              
Flag Coverage Δ
ml-commons 68.46% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arjunkumargiri arjunkumargiri marked this pull request as ready for review December 15, 2023 20:26
@ylwu-amzn ylwu-amzn merged commit 763971e into opensearch-project:feature/agent_framework_dev Dec 15, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants