-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding tests for all the agent runners #1783
Conversation
Signed-off-by: Dhrubo Saha <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1783 +/- ##
============================================
+ Coverage 82.69% 82.91% +0.22%
- Complexity 4744 4869 +125
============================================
Files 462 467 +5
Lines 18940 19674 +734
Branches 1976 2060 +84
============================================
+ Hits 15662 16313 +651
- Misses 2451 2500 +49
- Partials 827 861 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dhrubo Saha <[email protected]>
* adding tests for all the agent runners Signed-off-by: Dhrubo Saha <[email protected]> * added more tests Signed-off-by: Dhrubo Saha <[email protected]> * adding more tests Signed-off-by: Dhrubo Saha <[email protected]> * add tests Signed-off-by: Dhrubo Saha <[email protected]> * adding more tests Signed-off-by: Dhrubo Saha <[email protected]> * added more files and tests Signed-off-by: Dhrubo Saha <[email protected]> * addressing comments Signed-off-by: Dhrubo Saha <[email protected]> * addressing comments Signed-off-by: Dhrubo Saha <[email protected]> * merging PR 1785 Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit 2d5b1bb)
* adding tests for all the agent runners Signed-off-by: Dhrubo Saha <[email protected]> * added more tests Signed-off-by: Dhrubo Saha <[email protected]> * adding more tests Signed-off-by: Dhrubo Saha <[email protected]> * add tests Signed-off-by: Dhrubo Saha <[email protected]> * adding more tests Signed-off-by: Dhrubo Saha <[email protected]> * added more files and tests Signed-off-by: Dhrubo Saha <[email protected]> * addressing comments Signed-off-by: Dhrubo Saha <[email protected]> * addressing comments Signed-off-by: Dhrubo Saha <[email protected]> * merging PR 1785 Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit 2d5b1bb) Co-authored-by: Dhrubo Saha <[email protected]>
* adding tests for all the agent runners Signed-off-by: Dhrubo Saha <[email protected]> * added more tests Signed-off-by: Dhrubo Saha <[email protected]> * adding more tests Signed-off-by: Dhrubo Saha <[email protected]> * add tests Signed-off-by: Dhrubo Saha <[email protected]> * adding more tests Signed-off-by: Dhrubo Saha <[email protected]> * added more files and tests Signed-off-by: Dhrubo Saha <[email protected]> * addressing comments Signed-off-by: Dhrubo Saha <[email protected]> * addressing comments Signed-off-by: Dhrubo Saha <[email protected]> * merging PR 1785 Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]>
List<ModelTensor> modelTensors = new ArrayList<>(); | ||
outputs.add(ModelTensors.builder().mlModelTensors(modelTensors).build()); | ||
|
||
if (clusterService.state().metadata().hasIndex(ML_AGENT_INDEX)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be something like
if (!clusterService.state().metadata().hasIndex(ML_AGENT_INDEX)) {
listener.onFailure(new ResourceNotFoundException("Agent index not found"));
}
it's not returning a response when index is not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Joshua. @jngz-es help fix this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, will fix it in my pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #1866
* adding tests for all the agent runners Signed-off-by: Dhrubo Saha <[email protected]> * added more tests Signed-off-by: Dhrubo Saha <[email protected]> * adding more tests Signed-off-by: Dhrubo Saha <[email protected]> * add tests Signed-off-by: Dhrubo Saha <[email protected]> * adding more tests Signed-off-by: Dhrubo Saha <[email protected]> * added more files and tests Signed-off-by: Dhrubo Saha <[email protected]> * addressing comments Signed-off-by: Dhrubo Saha <[email protected]> * addressing comments Signed-off-by: Dhrubo Saha <[email protected]> * merging PR 1785 Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]>
Description
[adding tests for all the agent runners + refactoring the necessary code for the agent runners]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.