fix race confition in index initialization and RestUpdateConnector UT #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
austintlee and
HenryL27
as code owners
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
owaiskazi19
approved these changes
Jan 12, 2024
ylwu-amzn
approved these changes
Jan 12, 2024
b4sjoo
approved these changes
Jan 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
…#1852) Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 19c93b1)
ylwu-amzn
pushed a commit
that referenced
this pull request
Jan 12, 2024
…#1852) (#1857) Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 19c93b1) Co-authored-by: Xun Zhang <[email protected]>
Hailong-am
reviewed
Jan 12, 2024
| log.error("Failed to create index " + indexName, e); | ||
| internalListener.onFailure(e); | ||
| if (e instanceof ResourceAlreadyExistsException | ||
| || (e instanceof OpenSearchWrapperException && e.getCause() instanceof ResourceAlreadyExistsException)) { |
There was a problem hiding this comment.
a better one is to use org.opensearch.ExceptionsHelper.unwrap
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
…opensearch-project#1852) Signed-off-by: Xun Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the issue in #1851, and update the url in the RestUpdateConnector UT.
CI pass depends on the fix in #1846.
CI failed due to:
Tests with failures:
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.