-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix failing flaky tests due to pytorch library not available for dependency plugins #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency plugins Signed-off-by: Bhavana Ramaram <[email protected]>
rbhavna
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
January 16, 2024 20:23
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 20:23 — with
GitHub Actions
Failure
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 20:23 — with
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 20:23 — with
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 20:23 — with
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 20:23 — with
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 20:23 — with
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 20:52 — with
GitHub Actions
Failure
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 20:52 — with
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 20:52 — with
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 20:52 — with
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 20:52 — with
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 20:52 — with
GitHub Actions
Failure
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 21:24 — with
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 21:24 — with
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 21:24 — with
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 21:24 — with
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 21:24 — with
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 21:24 — with
GitHub Actions
Failure
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 22:41 — with
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 22:41 — with
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 22:41 — with
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 22:41 — with
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 22:41 — with
GitHub Actions
Error
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 22:41 — with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1876 +/- ##
=========================================
Coverage 82.61% 82.61%
+ Complexity 5389 5388 -1
=========================================
Files 521 521
Lines 21714 21714
Branches 2211 2211
=========================================
Hits 17940 17940
+ Misses 2876 2875 -1
- Partials 898 899 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 23:41 — with
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 23:41 — with
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 23:41 — with
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 23:41 — with
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 16, 2024 23:41 — with
GitHub Actions
Error
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 16, 2024 23:41 — with
GitHub Actions
Inactive
sam-herman
approved these changes
Jan 17, 2024
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 17, 2024 15:36 — with
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 17, 2024 15:36 — with
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 17, 2024 15:36 — with
GitHub Actions
Failure
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 17, 2024 15:37 — with
GitHub Actions
Inactive
rbhavna
temporarily deployed
to
ml-commons-cicd-env
January 17, 2024 15:37 — with
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
January 17, 2024 15:37 — with
GitHub Actions
Failure
ylwu-amzn
approved these changes
Jan 17, 2024
Zhangxunmt
approved these changes
Jan 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
…ndency plugins (#1876) Signed-off-by: Bhavana Ramaram <[email protected]> (cherry picked from commit c4b9cb1)
ylwu-amzn
pushed a commit
that referenced
this pull request
Jan 18, 2024
…ndency plugins (#1876) (#1886) Signed-off-by: Bhavana Ramaram <[email protected]> (cherry picked from commit c4b9cb1) Co-authored-by: Bhavana Ramaram <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
…ndency plugins (opensearch-project#1876) Signed-off-by: Bhavana Ramaram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are flaky tests failing on neural search plugin that need a deployed model to be used. But the pytorch model is failing to deploy due to EngineException failure with the error "Failed to load PyTorch native library".
Since pytorch-engine can load older version of pytorch native library, it could be possible a different version is being loaded than the expected one "pytorch-engine-0.21.0.jar". Here, we are explicitly specifying the required package version to override it to resolve the issue.
Issues Resolved
Fixes the flaky test: #1843
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.