Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing flaky tests due to pytorch library not available for dependency plugins #1876

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Jan 16, 2024

Description

There are flaky tests failing on neural search plugin that need a deployed model to be used. But the pytorch model is failing to deploy due to EngineException failure with the error "Failed to load PyTorch native library".

Since pytorch-engine can load older version of pytorch native library, it could be possible a different version is being loaded than the expected one "pytorch-engine-0.21.0.jar". Here, we are explicitly specifying the required package version to override it to resolve the issue.

Issues Resolved

Fixes the flaky test: #1843

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env January 16, 2024 20:23 — with GitHub Actions Failure
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 20:23 — with GitHub Actions Inactive
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env January 16, 2024 20:23 — with GitHub Actions Failure
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env January 16, 2024 20:52 — with GitHub Actions Failure
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 20:52 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 20:52 — with GitHub Actions Inactive
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env January 16, 2024 20:52 — with GitHub Actions Failure
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 21:24 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 21:24 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 21:24 — with GitHub Actions Inactive
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env January 16, 2024 21:24 — with GitHub Actions Failure
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 22:41 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 22:41 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 22:41 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 22:41 — with GitHub Actions Inactive
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38c71c6) 82.61% compared to head (6131325) 82.61%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1876   +/-   ##
=========================================
  Coverage     82.61%   82.61%           
+ Complexity     5389     5388    -1     
=========================================
  Files           521      521           
  Lines         21714    21714           
  Branches       2211     2211           
=========================================
  Hits          17940    17940           
+ Misses         2876     2875    -1     
- Partials        898      899    +1     
Flag Coverage Δ
ml-commons 82.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 23:41 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 23:41 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 23:41 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 23:41 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 16, 2024 23:41 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 17, 2024 15:36 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 17, 2024 15:36 — with GitHub Actions Inactive
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env January 17, 2024 15:36 — with GitHub Actions Failure
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 17, 2024 15:37 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 17, 2024 15:37 — with GitHub Actions Inactive
@rbhavna rbhavna had a problem deploying to ml-commons-cicd-env January 17, 2024 15:37 — with GitHub Actions Failure
@rbhavna rbhavna merged commit c4b9cb1 into opensearch-project:main Jan 17, 2024
10 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 17, 2024
…ndency plugins (#1876)

Signed-off-by: Bhavana Ramaram <[email protected]>
(cherry picked from commit c4b9cb1)
ylwu-amzn pushed a commit that referenced this pull request Jan 18, 2024
…ndency plugins (#1876) (#1886)

Signed-off-by: Bhavana Ramaram <[email protected]>
(cherry picked from commit c4b9cb1)

Co-authored-by: Bhavana Ramaram <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 19, 2024
@mingshl mingshl added the flaky-test Flaky build or test issue label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x flaky-test Flaky build or test issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants