-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system error handling #1893
Merged
Merged
system error handling #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngz-es
requested review from
b4sjoo,
dhrubo-os,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
January 21, 2024 23:01
jngz-es
had a problem deploying
to
ml-commons-cicd-env
January 21, 2024 23:01 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
January 21, 2024 23:01 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
January 21, 2024 23:01 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
January 21, 2024 23:01 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
January 21, 2024 23:01 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
January 21, 2024 23:01 — with
GitHub Actions
Error
mingshl
reviewed
Jan 22, 2024
plugin/src/main/java/org/opensearch/ml/rest/RestMLExecuteAction.java
Outdated
Show resolved
Hide resolved
Hailong-am
reviewed
Jan 25, 2024
plugin/src/main/java/org/opensearch/ml/utils/error/ErrorMessage.java
Outdated
Show resolved
Hide resolved
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 2, 2024 19:14 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 2, 2024 19:14 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 2, 2024 19:14 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 2, 2024 19:15 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 2, 2024 19:15 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 2, 2024 19:15 — with
GitHub Actions
Failure
Signed-off-by: Jing Zhang <[email protected]>
Signed-off-by: Jing Zhang <[email protected]>
jngz-es
force-pushed
the
error_handling
branch
from
February 3, 2024 01:58
3f3d639
to
408fefa
Compare
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 3, 2024 01:58 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 3, 2024 01:58 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 3, 2024 01:58 — with
GitHub Actions
Error
Signed-off-by: Jing Zhang <[email protected]>
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 6, 2024 04:57 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 6, 2024 04:57 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 6, 2024 04:57 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 6, 2024 04:58 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 6, 2024 04:58 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 6, 2024 04:58 — with
GitHub Actions
Error
Signed-off-by: Jing Zhang <[email protected]>
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 6, 2024 05:57 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 6, 2024 05:57 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
February 6, 2024 05:57 — with
GitHub Actions
Error
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 6, 2024 05:57 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 6, 2024 05:57 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 6, 2024 05:57 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 6, 2024 06:24 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 6, 2024 06:24 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
February 6, 2024 06:25 — with
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Feb 6, 2024
b4sjoo
approved these changes
Feb 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* system error handling Signed-off-by: Jing Zhang <[email protected]> * remove NullPointerException from client error Signed-off-by: Jing Zhang <[email protected]> * replace jsonobject with ObjectMapper Signed-off-by: Jing Zhang <[email protected]> * add more UT Signed-off-by: Jing Zhang <[email protected]> * fix format issue Signed-off-by: Jing Zhang <[email protected]> * spotless Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit c2a1d82)
jngz-es
added a commit
that referenced
this pull request
Feb 6, 2024
* system error handling Signed-off-by: Jing Zhang <[email protected]> * remove NullPointerException from client error Signed-off-by: Jing Zhang <[email protected]> * replace jsonobject with ObjectMapper Signed-off-by: Jing Zhang <[email protected]> * add more UT Signed-off-by: Jing Zhang <[email protected]> * fix format issue Signed-off-by: Jing Zhang <[email protected]> * spotless Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit c2a1d82) Co-authored-by: Jing Zhang <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
* system error handling Signed-off-by: Jing Zhang <[email protected]> * remove NullPointerException from client error Signed-off-by: Jing Zhang <[email protected]> * replace jsonobject with ObjectMapper Signed-off-by: Jing Zhang <[email protected]> * add more UT Signed-off-by: Jing Zhang <[email protected]> * fix format issue Signed-off-by: Jing Zhang <[email protected]> * spotless Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit c2a1d82)
ylwu-amzn
pushed a commit
that referenced
this pull request
Feb 8, 2024
* system error handling Signed-off-by: Jing Zhang <[email protected]> * remove NullPointerException from client error Signed-off-by: Jing Zhang <[email protected]> * replace jsonobject with ObjectMapper Signed-off-by: Jing Zhang <[email protected]> * add more UT Signed-off-by: Jing Zhang <[email protected]> * fix format issue Signed-off-by: Jing Zhang <[email protected]> * spotless Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit c2a1d82) Co-authored-by: Jing Zhang <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
* system error handling Signed-off-by: Jing Zhang <[email protected]> * remove NullPointerException from client error Signed-off-by: Jing Zhang <[email protected]> * replace jsonobject with ObjectMapper Signed-off-by: Jing Zhang <[email protected]> * add more UT Signed-off-by: Jing Zhang <[email protected]> * fix format issue Signed-off-by: Jing Zhang <[email protected]> * spotless Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catch all system error from agent when executing and wrap them into ErrorMessage to reply.
Tested on local testing cluster.
Some examples:
Old:
{
"error": {
"root_cause": [
{
"type": "illegal_argument_exception",
"reason": "Tool not found: VectorDBTool"
}
],
"type": "illegal_argument_exception",
"reason": "Tool not found: VectorDBTool"
},
"status": 400
}
New:
"{\n "error": {\n "reason": "Invalid Request",\n "details": "Tool not found: VectorDBTool",\n "type": "IllegalArgumentException"\n },\n "status": 400\n}"
Old:
{
"inference_results": [
{
"output": [
{
"result": """ ..."""
}
]
}
]
}
New:
{
"inference_results": [
{
"output": [
{
"name": "response",
"result": "..."
}
]
}
]
}
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.