-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stash thread context before running forward action #1904
Conversation
Signed-off-by: Yaliang Wu <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1904 +/- ##
=========================================
Coverage 82.61% 82.62%
- Complexity 5383 5388 +5
=========================================
Files 521 521
Lines 21715 21727 +12
Branches 2210 2211 +1
=========================================
+ Hits 17940 17952 +12
+ Misses 2878 2875 -3
- Partials 897 900 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deployModelDoneMessage, | ||
new ActionListenerResponseHandler<>(taskDoneListener, MLForwardResponse::new) | ||
); | ||
try (ThreadContext.StoredContext context = client.threadPool().getThreadContext().stashContext()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should fix the issue when multiple threads running in progress.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-1904-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a14521dd97397c2ec9f6899e5d7d2f450986a5f9
# Push it to GitHub
git push --set-upstream origin backport/backport-1904-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9 Then, create a pull request where the |
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit a14521d)
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit a14521d)
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit a14521d)
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit a14521d) Co-authored-by: Yaliang Wu <[email protected]>
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit a14521d) Co-authored-by: Yaliang Wu <[email protected]>
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit a14521d) Co-authored-by: Yaliang Wu <[email protected]>
…t#1904) Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Yaliang Wu <[email protected]>
…t#1904) Signed-off-by: Yaliang Wu <[email protected]>
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.