-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug in delete empty memory #1964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
austintlee and
HenryL27
as code owners
January 31, 2024 00:32
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:32 — with
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:33 — with
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:33 — with
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:33 — with
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:33 — with
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:33 — with
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:37 — with
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:37 — with
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:37 — with
GitHub Actions
Error
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 00:37 — with
GitHub Actions
Inactive
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:37 — with
GitHub Actions
Error
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:37 — with
GitHub Actions
Error
Zhangxunmt
changed the title
fix bug in delete empty memoty
fix bug in delete empty memory
Jan 31, 2024
ylwu-amzn
approved these changes
Jan 31, 2024
HenryL27
approved these changes
Jan 31, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 45e5199)
mingshl
pushed a commit
that referenced
this pull request
Jan 31, 2024
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Xun Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deleting a memory with no interactions, the response throws an error from the bulk delete interactions which is not expected.
This PR fixes the bug that when deleting an empty memory, the process should go through and delete it successfully.
Before the change:
After this change, the empty memory is deleted successfully.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.