Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape input data #1970

Merged
merged 2 commits into from
Jan 31, 2024
Merged

escape input data #1970

merged 2 commits into from
Jan 31, 2024

Conversation

ylwu-amzn
Copy link
Collaborator

Description

Escape input data to solve invalid payload error.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn
escape input data
28bb941 
Signed-off-by: Yaliang Wu <[email protected]>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 09:06 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 09:06 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 09:06 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 09:06 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 09:06 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 09:06 — with GitHub Actions Inactive
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (45e5199) 82.90% compared to head (c1fbe10) 82.85%.

Files Patch % Lines
...ch/ml/engine/algorithms/remote/ConnectorUtils.java 35.48% 19 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1970      +/-   ##
============================================
- Coverage     82.90%   82.85%   -0.06%     
- Complexity     5503     5507       +4     
============================================
  Files           533      533              
  Lines         22088    22109      +21     
  Branches       2244     2244              
============================================
+ Hits          18313    18319       +6     
- Misses         2859     2876      +17     
+ Partials        916      914       -2
Flag Coverage Δ
ml-commons 82.85% <54.54%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 09:34 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 09:34 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 09:34 — with GitHub Actions Inactive
@ylwu-amzn
add unit test
c1fbe10 
Signed-off-by: Yaliang Wu <[email protected]>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 16:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 16:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 16:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn marked this pull request as ready for review January 31, 2024 16:48
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 17:14 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 17:14 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 17:14 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 19:13 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 19:13 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 19:13 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 19:13 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 19:13 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env January 31, 2024 19:13 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn mentioned this pull request Jan 31, 2024
Closed
@ylwu-amzn ylwu-amzn merged commit 72d494c into opensearch-project:main Jan 31, 2024
9 of 14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2024
@ylwu-amzn @github-actions
escape input data (#1970)
8e1b01d 
* escape input data

Signed-off-by: Yaliang Wu <[email protected]>

* add unit test

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 72d494c)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 31, 2024
Merged
ylwu-amzn added a commit that referenced this pull request Jan 31, 2024
@opensearch-trigger-bot @ylwu-amzn
escape input data (#1970) (#1974)
2a7d214 
* escape input data

Signed-off-by: Yaliang Wu <[email protected]>

* add unit test

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 72d494c)

Co-authored-by: Yaliang Wu <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 19, 2024
@ylwu-amzn @austintlee
escape input data (opensearch-project#1970)
71d705d 
* escape input data

Signed-off-by: Yaliang Wu <[email protected]>

* add unit test

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngz-es jngz-es jngz-es approved these changes

@Zhangxunmt Zhangxunmt Zhangxunmt approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ylwu-amzn @Zhangxunmt @jngz-es