-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IndexMappingTool Description #1982
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
February 1, 2024 22:04
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 22:04 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 22:04 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 22:04 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 22:04 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 22:04 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 22:04 — with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1982 +/- ##
============================================
+ Coverage 82.84% 82.87% +0.03%
- Complexity 5505 5510 +5
============================================
Files 533 533
Lines 22098 22104 +6
Branches 2244 2244
============================================
+ Hits 18306 18319 +13
+ Misses 2876 2870 -6
+ Partials 916 915 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 22:31 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 22:31 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 22:31 — with
GitHub Actions
Inactive
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
index-mapping-desc
branch
from
February 1, 2024 23:36
7042dba
to
801c07e
Compare
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
February 1, 2024 23:36 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
February 1, 2024 23:36 — with
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
February 1, 2024 23:36 — with
GitHub Actions
Failure
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 23:37 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 23:37 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 1, 2024 23:37 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 2, 2024 00:05 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 2, 2024 00:05 — with
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
February 2, 2024 00:05 — with
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Feb 2, 2024
mingshl
approved these changes
Feb 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2024
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 34a9f8e)
mingshl
pushed a commit
that referenced
this pull request
Feb 3, 2024
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the description of the IndexMappingTool to include the expected output format. This improves LLM performance in understanding the tool output.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.