Remove logging of sensitive chat history. [issue 1965] #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Lee <[email protected]>
austintlee
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt and
HenryL27
as code owners
austintlee
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
austintlee
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
austintlee
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
austintlee
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
austintlee
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
austintlee
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2008 +/- ##
============================================
- Coverage 82.57% 82.55% -0.02%
+ Complexity 5577 5574 -3
============================================
Files 540 540
Lines 22453 22445 -8
Branches 2286 2286
============================================
- Hits 18540 18529 -11
- Misses 2981 2984 +3
Partials 932 932
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
austintlee
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
austintlee
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
austintlee
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
approved these changes
Feb 5, 2024
HenryL27
approved these changes
Feb 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
Signed-off-by: Austin Lee <[email protected]> (cherry picked from commit ddebae7)
Zhangxunmt
pushed a commit
that referenced
this pull request
Feb 5, 2024
Signed-off-by: Austin Lee <[email protected]> (cherry picked from commit ddebae7) Co-authored-by: Austin Lee <[email protected]>
austintlee
added a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
…oject#2008) Signed-off-by: Austin Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scrub sensitive log messages.
Issues Resolved
#1965
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.