-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance parsing model response function for more edge cases #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
February 16, 2024 11:29
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 11:29 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 11:29 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 11:29 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 11:30 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 11:30 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 11:30 — with
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2122 +/- ##
============================================
- Coverage 81.86% 81.86% -0.01%
- Complexity 5644 5657 +13
============================================
Files 543 543
Lines 22790 22843 +53
Branches 2333 2347 +14
============================================
+ Hits 18658 18701 +43
- Misses 3195 3203 +8
- Partials 937 939 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 11:57 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 11:57 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 11:57 — with
GitHub Actions
Inactive
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
February 16, 2024 16:41 — with
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
February 16, 2024 16:41 — with
GitHub Actions
Error
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 16:41 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 16:41 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 16:41 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 16:41 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 17:08 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 16, 2024 17:08 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 17, 2024 17:59 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 17, 2024 17:59 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 17, 2024 17:59 — with
GitHub Actions
Inactive
dhrubo-os
previously approved these changes
Feb 17, 2024
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 17, 2024 18:26 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 17, 2024 18:26 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 17, 2024 18:26 — with
GitHub Actions
Inactive
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
February 19, 2024 01:31 — with
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
February 19, 2024 01:31 — with
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
February 19, 2024 01:31 — with
GitHub Actions
Error
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 19, 2024 01:32 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 19, 2024 01:32 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 19, 2024 01:32 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 19, 2024 02:01 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 19, 2024 02:01 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
February 19, 2024 02:01 — with
GitHub Actions
Inactive
b4sjoo
approved these changes
Feb 19, 2024
dhrubo-os
approved these changes
Feb 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
* enhance parsing model response function for more edge cases Signed-off-by: Yaliang Wu <[email protected]> * add more unit test Signed-off-by: Yaliang Wu <[email protected]> * fine tune code; fix some bug Signed-off-by: Yaliang Wu <[email protected]> * add more unit test Signed-off-by: Yaliang Wu <[email protected]> * fix tool name bug Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 311b971)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
* enhance parsing model response function for more edge cases Signed-off-by: Yaliang Wu <[email protected]> * add more unit test Signed-off-by: Yaliang Wu <[email protected]> * fine tune code; fix some bug Signed-off-by: Yaliang Wu <[email protected]> * add more unit test Signed-off-by: Yaliang Wu <[email protected]> * fix tool name bug Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 311b971)
ylwu-amzn
added a commit
that referenced
this pull request
Feb 19, 2024
…2129) * enhance parsing model response function for more edge cases Signed-off-by: Yaliang Wu <[email protected]> * add more unit test Signed-off-by: Yaliang Wu <[email protected]> * fine tune code; fix some bug Signed-off-by: Yaliang Wu <[email protected]> * add more unit test Signed-off-by: Yaliang Wu <[email protected]> * fix tool name bug Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 311b971) Co-authored-by: Yaliang Wu <[email protected]>
ylwu-amzn
added a commit
that referenced
this pull request
Feb 19, 2024
…2128) * enhance parsing model response function for more edge cases Signed-off-by: Yaliang Wu <[email protected]> * add more unit test Signed-off-by: Yaliang Wu <[email protected]> * fine tune code; fix some bug Signed-off-by: Yaliang Wu <[email protected]> * add more unit test Signed-off-by: Yaliang Wu <[email protected]> * fix tool name bug Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 311b971) Co-authored-by: Yaliang Wu <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
…ch-project#2122) * enhance parsing model response function for more edge cases Signed-off-by: Yaliang Wu <[email protected]> * add more unit test Signed-off-by: Yaliang Wu <[email protected]> * fine tune code; fix some bug Signed-off-by: Yaliang Wu <[email protected]> * add more unit test Signed-off-by: Yaliang Wu <[email protected]> * fix tool name bug Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance parsing model response function for more edge cases
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.