-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport main] adding BWC for connector config field #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit ce6f7e1)
opensearch-trigger-bot
bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
March 8, 2024 00:47
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
==========================================
Coverage 81.89% 81.90%
- Complexity 5690 5718 +28
==========================================
Files 545 547 +2
Lines 22941 23063 +122
Branches 2364 2378 +14
==========================================
+ Hits 18788 18890 +102
- Misses 3211 3228 +17
- Partials 942 945 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dhrubo-os
approved these changes
Mar 8, 2024
b4sjoo
approved these changes
Mar 8, 2024
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 18, 2024
…search-project#2185) Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit ce6f7e1) Co-authored-by: Dhrubo Saha <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
…search-project#2185) Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit ce6f7e1) Co-authored-by: Dhrubo Saha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ce6f7e1 from #2184