Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remote predict thread pool #2207

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

ylwu-amzn
Copy link
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os
Copy link
Collaborator

  1. This PR is not running integration test workflow
  2. Can we add corresponding unit test?

@peterzhuamazon
Copy link
Member

Re-open to trigger the corresponding github actions.

@peterzhuamazon peterzhuamazon temporarily deployed to ml-commons-cicd-env March 18, 2024 21:25 — with GitHub Actions Inactive
@peterzhuamazon peterzhuamazon temporarily deployed to ml-commons-cicd-env March 18, 2024 21:25 — with GitHub Actions Inactive
@peterzhuamazon peterzhuamazon temporarily deployed to ml-commons-cicd-env March 18, 2024 21:25 — with GitHub Actions Inactive
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.91%. Comparing base (c233356) to head (f33b949).

Files Patch % Lines
...va/org/opensearch/ml/task/MLPredictTaskRunner.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2207   +/-   ##
=========================================
  Coverage     81.91%   81.91%           
- Complexity     5719     5721    +2     
=========================================
  Files           547      547           
  Lines         23064    23075   +11     
  Branches       2378     2378           
=========================================
+ Hits          18892    18903   +11     
  Misses         3227     3227           
  Partials        945      945           
Flag Coverage Δ
ml-commons 81.91% <94.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon peterzhuamazon temporarily deployed to ml-commons-cicd-env March 18, 2024 21:53 — with GitHub Actions Inactive
@peterzhuamazon peterzhuamazon temporarily deployed to ml-commons-cicd-env March 18, 2024 21:53 — with GitHub Actions Inactive
@peterzhuamazon peterzhuamazon temporarily deployed to ml-commons-cicd-env March 18, 2024 21:53 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit 189f2a2 into opensearch-project:main Mar 19, 2024
15 of 18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 189f2a2)
Zhangxunmt pushed a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 189f2a2)

Co-authored-by: Yaliang Wu <[email protected]>
Zhangxunmt pushed a commit to Zhangxunmt/ml-commons that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants