Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix json error #2234

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix json error #2234

merged 1 commit into from
Mar 19, 2024

Conversation

jngz-es
Copy link
Collaborator

@jngz-es jngz-es commented Mar 19, 2024

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:15 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:15 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:15 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:15 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:15 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:15 — with GitHub Actions Error
@dhrubo-os
Copy link
Collaborator 

{"error":{"root_cause":[{"type":"mapper_parsing_exception","reason":"Root mapping definition has unsupported parameters:  [guardrails : {type=flat_object}]"}],"type":"mapper_parsing_exception","reason":"Failed to parse mapping [_doc]: Root mapping definition has unsupported parameters:  [guardrails : {type=flat_object}]","caused_by":{"type":"mapper_parsing_exception","reason":"Root mapping definition has unsupported parameters:  [guardrails : {type=flat_object}]"}},"status":400}

As we discussed we need to put this field inside of properties

@jngz-es
fix json error
8ed1cee 
Signed-off-by: Jing Zhang <[email protected]>
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:52 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:52 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:52 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:52 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:52 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 19, 2024 21:52 — with GitHub Actions Error
ylwu-amzn
ylwu-amzn reviewed Mar 19, 2024
View reviewed changes
common/src/main/java/org/opensearch/ml/common/CommonValue.java
@@ -262,13 +262,13 @@ public class CommonValue {
+ MLModel.LAST_UNDEPLOYED_TIME_FIELD
+ "\": {\"type\": \"date\", \"format\": \"strict_date_time||epoch_millis\"},\n"
+ " \""
+ MLModel.GUARDRAILS_FIELD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified if the index mapping is valid ? You can manually try it in OSD dev tools

@dhrubo-os
Copy link
Collaborator 

Tests with failures:
1106 tests completed, 1 failed, 58 skipped
 - org.opensearch.ml.task.MLPredictTaskRunnerTests.testExecuteTask_OnLocalNode_RemoteModel

I think the core problem is solved. This is could be due to @Zhangxunmt's integration test failure?

@Zhangxunmt
Copy link
Collaborator

Let's merge sooner than later to unblock other tests.

@Zhangxunmt Zhangxunmt merged commit 461199a into opensearch-project:main Mar 19, 2024
4 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 19, 2024
@jngz-es @github-actions
fix json error (#2234)
4679c39 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 461199a)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 19, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 19, 2024
@jngz-es @github-actions
fix json error (#2234)
4cdc261 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 461199a)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 19, 2024
Merged
jngz-es added a commit that referenced this pull request Mar 19, 2024
@opensearch-trigger-bot @jngz-es
fix json error (#2234) (#2239)
94146c7 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 461199a)

Co-authored-by: Jing Zhang <[email protected]>
jngz-es added a commit that referenced this pull request Mar 19, 2024
@opensearch-trigger-bot @jngz-es
fix json error (#2234) (#2240)
2b7479b 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 461199a)

Co-authored-by: Jing Zhang <[email protected]>
@dhrubo-os dhrubo-os mentioned this pull request Mar 20, 2024
Merged
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 20, 2024
@jngz-es @austintlee
fix json error (opensearch-project#2234)
ebee2fe 
Signed-off-by: Jing Zhang <[email protected]>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 20, 2024
@jngz-es @austintlee
fix json error (opensearch-project#2234)
52653c1 
Signed-off-by: Jing Zhang <[email protected]>
@jngz-es jngz-es deleted the json_error branch June 10, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylwu-amzn ylwu-amzn ylwu-amzn left review comments

@dhrubo-os dhrubo-os dhrubo-os approved these changes

@Zhangxunmt Zhangxunmt Zhangxunmt approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman

Assignees
No one assigned
Labels
backport 2.x backport 2.13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jngz-es @dhrubo-os @Zhangxunmt @ylwu-amzn