Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 2.x: Add integration tests for the RAG pipeline covering OpenAI and Bedroc… #2246

Merged

Conversation

austintlee
Copy link
Collaborator

…k (#2213)

  • Add integration tests for the RAG pipeline covering OpenAI and Bedrock.

Signed-off-by: Austin Lee [email protected]

  • Use us-west-2 for testing.

Signed-off-by: Austin Lee [email protected]

  • Fix spotless

Signed-off-by: Austin Lee [email protected]

  • Fix broken import.

Signed-off-by: Austin Lee [email protected]

  • Fix loading of default feature flag settings, update tests to pick up changes in memory API.

Signed-off-by: Austin Lee [email protected]

  • Remove unused code.

Signed-off-by: Austin Lee [email protected]

  • Remove unused code.

Signed-off-by: Austin Lee [email protected]


Signed-off-by: Austin Lee [email protected]
(cherry picked from commit d645c83)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-project#2213)

* Add integration tests for the RAG pipeline covering OpenAI and Bedrock.

Signed-off-by: Austin Lee <[email protected]>

* Use us-west-2 for testing.

Signed-off-by: Austin Lee <[email protected]>

* Fix spotless

Signed-off-by: Austin Lee <[email protected]>

* Fix broken import.

Signed-off-by: Austin Lee <[email protected]>

* Fix loading of default feature flag settings, update tests to pick up
changes in memory API.

Signed-off-by: Austin Lee <[email protected]>

* Remove unused code.

Signed-off-by: Austin Lee <[email protected]>

* Remove unused code.

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit d645c83)
Signed-off-by: Austin Lee <[email protected]>
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 01:39 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 01:39 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 01:39 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 01:40 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 01:40 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 01:40 — with GitHub Actions Inactive
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (bda2995) to head (2626db6).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #2246   +/-   ##
=========================================
  Coverage     81.30%   81.31%           
  Complexity     5833     5833           
=========================================
  Files           557      557           
  Lines         23819    23821    +2     
  Branches       2480     2480           
=========================================
+ Hits          19367    19369    +2     
  Misses         3431     3431           
  Partials       1021     1021           
Flag Coverage Δ
ml-commons 81.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 02:27 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 02:27 — with GitHub Actions Inactive
@austintlee austintlee temporarily deployed to ml-commons-cicd-env March 20, 2024 02:27 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit cc79028 into opensearch-project:2.x Mar 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants