Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add request level parameters for system_prompt and user_instructions. #2250

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 80c9908 from #2236

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.34%. Comparing base (cc79028) to head (9cbc61f).

Files Patch % Lines
...swering/generative/ext/GenerativeQAParameters.java 85.71% 0 Missing and 2 partials ⚠️
...ring/generative/GenerativeQAResponseProcessor.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #2250      +/-   ##
============================================
+ Coverage     81.33%   81.34%   +0.01%     
- Complexity     5843     5844       +1     
============================================
  Files           557      557              
  Lines         23838    23858      +20     
  Branches       2485     2489       +4     
============================================
+ Hits          19388    19407      +19     
- Misses         3425     3427       +2     
+ Partials       1025     1024       -1     
Flag Coverage Δ
ml-commons 81.34% <85.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhrubo-os dhrubo-os merged commit 4dc590b into 2.x Mar 20, 2024
12 of 15 checks passed
@github-actions github-actions bot deleted the backport/backport-2236-to-2.x branch March 20, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants