Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restrict stash context only for stop words system index #2283

Merged
merged 1 commit into from
Mar 27, 2024
Merged

restrict stash context only for stop words system index #2283

merged 1 commit into from
Mar 27, 2024

Conversation

jngz-es
Copy link
Collaborator

@jngz-es jngz-es commented Mar 27, 2024

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 27, 2024 19:51 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 27, 2024 19:51 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 27, 2024 19:51 — with GitHub Actions Error
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env March 27, 2024 19:51 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env March 27, 2024 19:51 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env March 27, 2024 19:51 — with GitHub Actions Inactive
@jngz-es jngz-es mentioned this pull request Mar 27, 2024
Merged
5 tasks
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 81.38%. Comparing base (be56bcf) to head (2c1cd6d).
Report is 1 commits behind head on main.

❗ Current head 2c1cd6d differs from pull request most recent head 3e1cc6d. Consider uploading reports for the commit 3e1cc6d to get more accurate results

Files Patch % Lines
...n/java/org/opensearch/ml/common/model/MLGuard.java 9.09% 19 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2283      +/-   ##
============================================
- Coverage     81.42%   81.38%   -0.05%     
+ Complexity     5853     5850       -3     
============================================
  Files           557      557              
  Lines         23871    23884      +13     
  Branches       2493     2495       +2     
============================================
+ Hits          19436    19437       +1     
- Misses         3412     3425      +13     
+ Partials       1023     1022       -1
Flag Coverage Δ
ml-commons 81.38% <9.09%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 27, 2024 20:39 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 27, 2024 20:39 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 27, 2024 20:39 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 27, 2024 20:39 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 27, 2024 20:39 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env March 27, 2024 20:39 — with GitHub Actions Error
@jngz-es jngz-es requested a review from lezzago March 27, 2024 20:48
Zhangxunmt
Zhangxunmt approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@Zhangxunmt Zhangxunmt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding UT to cover the new code?

@jngz-es jngz-es merged commit 5f9026d into opensearch-project:main Mar 27, 2024
5 of 11 checks passed
@jngz-es jngz-es deleted the guardrails branch March 27, 2024 21:04
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 27, 2024
@jngz-es @github-actions
restrict stash context only for stop words system index (#2283)
9fd04a5 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 5f9026d)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 27, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 27, 2024
@jngz-es @github-actions
restrict stash context only for stop words system index (#2283)
be6dcbb 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 5f9026d)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 27, 2024
Merged
jngz-es added a commit that referenced this pull request Mar 27, 2024
@opensearch-trigger-bot @jngz-es
restrict stash context only for stop words system index (#2283) (#2284)
507e749 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 5f9026d)

Co-authored-by: Jing Zhang <[email protected]>
jngz-es added a commit that referenced this pull request Mar 27, 2024
@opensearch-trigger-bot @jngz-es
restrict stash context only for stop words system index (#2283) (#2285)
4dbeb28 
Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 5f9026d)

Co-authored-by: Jing Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b4sjoo b4sjoo b4sjoo approved these changes

@Zhangxunmt Zhangxunmt Zhangxunmt approved these changes

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

@lezzago lezzago Awaiting requested review from lezzago

Assignees
No one assigned
Labels
backport 2.x backport 2.13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jngz-es @lezzago @Zhangxunmt @b4sjoo