agent out of the setting only_run_on_ml_node #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jing Zhang <[email protected]>
jngz-es
requested review from
b4sjoo,
dhrubo-os,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
b4sjoo
previously approved these changes
Apr 8, 2024
dhrubo-os
reviewed
Apr 8, 2024
| @@ -73,7 +73,7 @@ public DiscoveryNode[] getEligibleNodes(FunctionName functionName) { | |||
| if (excludedNodeNames != null && excludedNodeNames.contains(node.getName())) { | |||
| continue; | |||
| } | |||
| if (functionName == FunctionName.REMOTE) {// remote model | |||
| if (functionName == FunctionName.REMOTE || functionName == FunctionName.AGENT) {// remote model | |||
There was a problem hiding this comment.
[nit] update the comment as well?
Zhangxunmt
previously approved these changes
Apr 8, 2024
Signed-off-by: Jing Zhang <[email protected]>
jngz-es
dismissed stale reviews from Zhangxunmt, ylwu-amzn, and b4sjoo
via
66905bd
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Apr 8, 2024
Zhangxunmt
approved these changes
Apr 8, 2024
dhrubo-os
approved these changes
Apr 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
* agent out of the setting only_run_on_ml_node Signed-off-by: Jing Zhang <[email protected]> * address comments Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit e3e72f7)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
* agent out of the setting only_run_on_ml_node Signed-off-by: Jing Zhang <[email protected]> * address comments Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit e3e72f7)
jngz-es
added a commit
that referenced
this pull request
Apr 8, 2024
* agent out of the setting only_run_on_ml_node Signed-off-by: Jing Zhang <[email protected]> * address comments Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit e3e72f7) Co-authored-by: Jing Zhang <[email protected]>
jngz-es
added a commit
that referenced
this pull request
Apr 8, 2024
* agent out of the setting only_run_on_ml_node Signed-off-by: Jing Zhang <[email protected]> * address comments Signed-off-by: Jing Zhang <[email protected]> --------- Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit e3e72f7) Co-authored-by: Jing Zhang <[email protected]>
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Take agent out of the scope of only_run_on_ml_node flag.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.