-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connector can use subfield of ARN #2320
Conversation
…credential from AWS Signed-off-by: Sicheng Song <[email protected]>
common/src/main/java/org/opensearch/ml/common/transport/connector/MLCreateConnectorInput.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/opensearch/ml/common/transport/connector/MLCreateConnectorInput.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Sicheng Song <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2320-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 650d312b05a3ab7a6d14abd78e8026c6d70e7ad9
# Push it to GitHub
git push --set-upstream origin backport/backport-2320-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…credential from AWS (opensearch-project#2320) * Fix connector can use subfield of secrectArn to bypass extraction of credential from AWS Signed-off-by: Sicheng Song <[email protected]> * Forbid all kinds of ARN subfield Signed-off-by: Sicheng Song <[email protected]> * Adjust annotation Signed-off-by: Sicheng Song <[email protected]> --------- Signed-off-by: Sicheng Song <[email protected]>
…credential from AWS (#2320) (#2321) * Fix connector can use subfield of secrectArn to bypass extraction of credential from AWS * Forbid all kinds of ARN subfield * Adjust annotation --------- Signed-off-by: Sicheng Song <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.13 2.13
# Navigate to the new working tree
cd .worktrees/backport-2.13
# Create a new branch
git switch --create backport/backport-2320-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 650d312b05a3ab7a6d14abd78e8026c6d70e7ad9
# Push it to GitHub
git push --set-upstream origin backport/backport-2320-to-2.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.13 Then, create a pull request where the |
…credential from AWS (opensearch-project#2320) (opensearch-project#2321) * Fix connector can use subfield of secrectArn to bypass extraction of credential from AWS * Forbid all kinds of ARN subfield * Adjust annotation --------- Signed-off-by: Sicheng Song <[email protected]>
…credential from AWS (opensearch-project#2320) (opensearch-project#2321) * Fix connector can use subfield of secrectArn to bypass extraction of credential from AWS * Forbid all kinds of ARN subfield * Adjust annotation --------- Signed-off-by: Sicheng Song <[email protected]>
…credential from AWS (opensearch-project#2320) (opensearch-project#2321) * Fix connector can use subfield of secrectArn to bypass extraction of credential from AWS * Forbid all kinds of ARN subfield * Adjust annotation --------- Signed-off-by: Sicheng Song <[email protected]>
Description
Filter out any key string which tries to imitate the subfield of the ARN in the credential map. UT has added.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.