Expose ML Config API #2850
Merged
Expose ML Config API #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Agrawal <[email protected]>
lezzago
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
lezzago
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
lezzago
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
lezzago
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
|
@lezzago Hi can I know why we are going to store agent info in config index? |
dhrubo-os
reviewed
Aug 28, 2024
| @@ -951,6 +959,26 @@ public void listTools() { | |||
| assertEquals("Use this tool to search general knowledge on wikipedia.", argumentCaptor.getValue().get(0).getDescription()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void getConfig() { | |||
There was a problem hiding this comment.
Can we add a test for MASTER_KEY showing that its getting rejected?
This is already being used for the |
Signed-off-by: Ashish Agrawal <[email protected]>
lezzago
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
lezzago
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
lezzago
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
lezzago
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
approved these changes
Aug 28, 2024
rbhavna
approved these changes
Aug 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
* Expose ML Config API Signed-off-by: Ashish Agrawal <[email protected]> * Add tests for rejected master key Signed-off-by: Ashish Agrawal <[email protected]> --------- Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 05eb53f)
dhrubo-os
pushed a commit
that referenced
this pull request
Aug 29, 2024
* Expose ML Config API Signed-off-by: Ashish Agrawal <[email protected]> * Add tests for rejected master key Signed-off-by: Ashish Agrawal <[email protected]> --------- Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 05eb53f) Co-authored-by: Ashish Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose ML Config API
Related Issues
N/A
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.