Updates dev guide to inform the workflow approval step #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Flores <[email protected]>
brianf-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
opensearch-trigger-bot
bot
added
the
documentation
brianf-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
brianf-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
brianf-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
jngz-es
previously approved these changes
Oct 4, 2024
pyek-bot
approved these changes
Oct 11, 2024
dhrubo-os
reviewed
Oct 11, 2024
Signed-off-by: Brian Flores <[email protected]>
brianf-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
brianf-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dhrubo-os
approved these changes
Oct 11, 2024
brianf-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
|
Let's request a review from another maintainer and get this merged! |
ylwu-amzn
approved these changes
Oct 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Updates dev guide to inform the workflow approval step Signed-off-by: Brian Flores <[email protected]> * Adjusted reason for workflow approval Signed-off-by: Brian Flores <[email protected]> --------- Signed-off-by: Brian Flores <[email protected]> (cherry picked from commit 09ee93f)
ylwu-amzn
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Updates dev guide to inform the workflow approval step Signed-off-by: Brian Flores <[email protected]> * Adjusted reason for workflow approval Signed-off-by: Brian Flores <[email protected]> --------- Signed-off-by: Brian Flores <[email protected]> (cherry picked from commit 09ee93f) Co-authored-by: Brian Flores <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of October 2nd 2024, you will need to ask for maintainer approval to run the GitHub
CI/CD workflow actions to see your code changes build on pushing your PR.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.