-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport to 2.x] Backport #3260 and #3329 #3353
Merged
dhrubo-os
merged 1 commit into
opensearch-project:2.x
from
akolarkunnu:backportconnectorcreatevalidations
Jan 9, 2025
Merged
[Backport to 2.x] Backport #3260 and #3329 #3353
dhrubo-os
merged 1 commit into
opensearch-project:2.x
from
akolarkunnu:backportconnectorcreatevalidations
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backporting these two PRs together becasue auto backporting of 3260 failed becasue of usage of Text Blocks, 3329 is to revert the usage of Text Blocks. Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
akolarkunnu
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
January 9, 2025 05:44
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
January 9, 2025 05:44 — with
GitHub Actions
Inactive
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
January 9, 2025 05:44 — with
GitHub Actions
Error
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
January 9, 2025 05:44 — with
GitHub Actions
Inactive
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
January 9, 2025 05:44 — with
GitHub Actions
Error
akolarkunnu
temporarily deployed
to
ml-commons-cicd-env-require-approval
January 9, 2025 05:44 — with
GitHub Actions
Inactive
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
January 9, 2025 05:44 — with
GitHub Actions
Failure
4 tasks
ylwu-amzn
changed the title
Backport #3260 and #3329
[Backport to 2.x] Backport #3260 and #3329
Jan 9, 2025
flaky test
|
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
January 9, 2025 16:03 — with
GitHub Actions
Error
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
January 9, 2025 16:03 — with
GitHub Actions
Error
akolarkunnu
had a problem deploying
to
ml-commons-cicd-env-require-approval
January 9, 2025 16:03 — with
GitHub Actions
Failure
dhrubo-os
approved these changes
Jan 9, 2025
ylwu-amzn
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting these two PRs together becasue auto backporting of 3260 failed becasue of usage of Text Blocks, 3329 is to revert the usage of Text Blocks.
Related Issues
Back porting #3260 and #3329
Check List
- [ ] New functionality has been documented.--signoff
.- [ ] Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.