Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 2.x] Backport #3260 and #3329 #3353

Conversation

akolarkunnu
Copy link
Contributor

Description

Backporting these two PRs together becasue auto backporting of 3260 failed becasue of usage of Text Blocks, 3329 is to revert the usage of Text Blocks.

Related Issues

Back porting #3260 and #3329

Check List

  • New functionality includes testing.
    - [ ] New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
    - [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Backporting these two PRs together becasue auto backporting of 3260 failed becasue of usage of Text Blocks, 3329 is to revert the usage of Text Blocks.

Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
@akolarkunnu akolarkunnu temporarily deployed to ml-commons-cicd-env-require-approval January 9, 2025 05:44 — with GitHub Actions Inactive
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval January 9, 2025 05:44 — with GitHub Actions Error
@akolarkunnu akolarkunnu temporarily deployed to ml-commons-cicd-env-require-approval January 9, 2025 05:44 — with GitHub Actions Inactive
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval January 9, 2025 05:44 — with GitHub Actions Error
@akolarkunnu akolarkunnu temporarily deployed to ml-commons-cicd-env-require-approval January 9, 2025 05:44 — with GitHub Actions Inactive
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval January 9, 2025 05:44 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn changed the title Backport #3260 and #3329 [Backport to 2.x] Backport #3260 and #3329 Jan 9, 2025
@mingshl
Copy link
Collaborator

mingshl commented Jan 9, 2025

flaky test

VisualizationsToolIT > testVisualizationNotFound STANDARD_ERROR

REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationNotFound" -Dtests.seed=5104228CAE946F91 -Dtests.security.manager=false -Dtests.locale=nn-NO -Dtests.timezone=America/Recife -Druntime.java=21
    REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.tools.VisualizationsToolIT.testVisualizationNotFound" -Dtests.seed=5104228CAE946F91 -Dtests.security.manager=false -Dtests.locale=nn-NO -Dtests.timezone=America/Recife -Druntime.java=21

VisualizationsToolIT > testVisualizationNotFound FAILED
    java.lang.AssertionError: The response failed to meet condition after 6 attempts. Attempted to perform GET : /_plugins/_ml/models/rmAQSpQBPhhQAunzksG4
        at __randomizedtesting.SeedInfo.seed([5104228CAE946F91:9E678611A9A75591]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.opensearch.ml.tools.ToolIntegrationWithLLMTest.waitResponseMeetingCondition(ToolIntegrationWithLLMTest.java:103)
        at org.opensearch.ml.tools.ToolIntegrationWithLLMTest.checkForModelUndeployedStatus(ToolIntegrationWithLLMTest.java:89)
        at org.opensearch.ml.tools.ToolIntegrationWithLLMTest.deleteModel(ToolIntegrationWithLLMTest.java:74)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
        at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
        at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
        at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
        at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)

@dhrubo-os dhrubo-os merged commit 01d1349 into opensearch-project:2.x Jan 9, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants