Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spotless Check to maintain consistency #3386

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

rithin-pullela-aws
Copy link
Contributor

Description

Added Spotless check step to main branch to maintain workflow consistency with 2.x branch. While version compatibility is only an issue in 2.x, maintaining parallel workflow structure prevents branch drift and simplifies future maintenance.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Add Spotless check step to main branch to maintain workflow consistency
with 2.x branch. While version compatibility is only an issue in 2.x,
maintaining parallel workflow structure prevents branch drift and
simplifies future maintenance.

Signed-off-by: rithin-pullela-aws <[email protected]>
Copy link
Member

@yuye-aws yuye-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR. The code looks good to me.

@yuye-aws
Copy link
Member

@ylwu-amzn How about backporting this PR to 2.x branch?

@rithin-pullela-aws rithin-pullela-aws temporarily deployed to ml-commons-cicd-env-require-approval January 14, 2025 03:32 — with GitHub Actions Inactive
@rithin-pullela-aws
Copy link
Contributor Author

@ylwu-amzn How about backporting this PR to 2.x branch?

Backporting is not required for this PR

@dhrubo-os
Copy link
Collaborator

@ylwu-amzn How about backporting this PR to 2.x branch?

Backporting isn't necessary in favor of this PR

@dhrubo-os dhrubo-os merged commit 5fd7450 into opensearch-project:main Jan 14, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants